From 67e56cd76e226dfdd6dc731d33cf668f706b1bec Mon Sep 17 00:00:00 2001 From: Gareth Rees Date: Mon, 11 Sep 2023 17:47:21 +0100 Subject: [PATCH] Add colon after request summary intro MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Apple Mail (and potentially others) renders the next line immediately after this line, so it reads as a continuation which gets confusing: > Here's your daily request summary from WhatDoTheyKnow Production, > and supply of foo… After this change we'll have: > Here's your daily request summary from WhatDoTheyKnow: Production, > and supply of foo… --- app/views/notification_mailer/daily_summary.text.erb | 2 +- spec/fixtures/files/notification_mailer/daily-summary.txt | 2 +- spec/views/notification_mailer/daily_summary.text.erb_spec.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/views/notification_mailer/daily_summary.text.erb b/app/views/notification_mailer/daily_summary.text.erb index dc527918a5..00cdb7ae8a 100644 --- a/app/views/notification_mailer/daily_summary.text.erb +++ b/app/views/notification_mailer/daily_summary.text.erb @@ -1,4 +1,4 @@ -<%= _("Here's your daily request summary from {{site_name}}", +<%= _("Here's your daily request summary from {{site_name}}:", site_name: site_name.html_safe) %> <% @grouped_notifications.each do |request, notifications| %> diff --git a/spec/fixtures/files/notification_mailer/daily-summary.txt b/spec/fixtures/files/notification_mailer/daily-summary.txt index 2f3f65a5b7..b34f2ba69f 100644 --- a/spec/fixtures/files/notification_mailer/daily-summary.txt +++ b/spec/fixtures/files/notification_mailer/daily-summary.txt @@ -1,4 +1,4 @@ -Here's your daily request summary from Alaveteli +Here's your daily request summary from Alaveteli: The cost of paperclips ---------------------- diff --git a/spec/views/notification_mailer/daily_summary.text.erb_spec.rb b/spec/views/notification_mailer/daily_summary.text.erb_spec.rb index b3e97c1fec..8ac4b19407 100644 --- a/spec/views/notification_mailer/daily_summary.text.erb_spec.rb +++ b/spec/views/notification_mailer/daily_summary.text.erb_spec.rb @@ -16,6 +16,6 @@ render expect(response).to match("the l'Information team") expect(response). - to match("Here's your daily request summary from l'Information") + to match("Here's your daily request summary from l'Information:") end end