Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove material from caches as soon as it is hidden #1475

Closed
RichardTaylor opened this issue May 6, 2014 · 8 comments
Closed

Remove material from caches as soon as it is hidden #1475

RichardTaylor opened this issue May 6, 2014 · 8 comments
Labels
f:admin f:redaction improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) reduce-admin Reduce issues coming to us in the first place wdtk-team-priority

Comments

@RichardTaylor
Copy link

Regularly when administrators remove material from the site, and notify complainants, the complainants complain again saying the material is still visible to them, and it remains so for quite a few minutes.

The issue can be a message still appearing to them on a request thread; or it can be an appearance in search results, or the "similar requests" side bar.

Ideally when an administrator hides a request it ought be immediately removed from public view.

@MattK1234
Copy link
Collaborator

WDTK-team-priority tag added following discussion on the catch-up call 25/08/2020

@garethrees
Copy link
Member

We don't think this is the 5-10 minute lag of Xapian search indexing – much more likely to be Varnish/browser cache related. A thing to investigate is whether some misconfiguration of Varnish has crept in over the years as its been upgraded, etc.

@RichardTaylor
Copy link
Author

In the last week or so I've observed redactions / changes to have all taken place straight away. I've not recently seen caching to be an issue.

@RichardTaylor
Copy link
Author

I've just done another redaction of request/response message text on WhatDoTheyKnow which was immediately effective for non-logged in users - this didn't used to happen - something has changed for the better.

@RichardTaylor
Copy link
Author

This is of course still a regular issue for site admins on WhatDoTheyKnow.

@RichardTaylor
Copy link
Author

Just to note that today I hit no issues with caching. A couple of times I checked a request page I'd just changed from the point of view of a non logged in user and it already reflected the change I'd just made.

Perhaps neither I or anyone else had recently requested the page as a non-logged in user before I did to check material had gone?

@garethrees garethrees added the reduce-admin Reduce issues coming to us in the first place label Sep 26, 2022
@dracos
Copy link
Member

dracos commented Sep 19, 2023

#7893 means there is now a VARNISH_HOSTS configuration option; if set (to hosts holding proxy caches, e.g. load balancers), it will use background jobs to send relevant PURGE or BAN requests to each of the hosts listed at appropriate times. If those hosts are then set up to action such requests (following e.g. https://varnish-cache.org/docs/trunk/users-guide/purging.html ), their cache entries will be invalidated.

@garethrees
Copy link
Member

Considering closed via #7893. Can open new tickets for issues that doesn't resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:admin f:redaction improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) reduce-admin Reduce issues coming to us in the first place wdtk-team-priority
Projects
None yet
Development

No branches or pull requests

5 participants