Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tags to have notes #6994

Closed
garethrees opened this issue Apr 27, 2022 · 0 comments · Fixed by #7212
Closed

Allow tags to have notes #6994

garethrees opened this issue Apr 27, 2022 · 0 comments · Fixed by #7212
Assignees
@gbp
Labels
enhancement Adds new functionality f:admin x:uk
Milestone
Generalised Notes

Comments

@garethrees
Copy link
Member

A tag should be "notable" (#6931) so that we can display additional context in cases where we're trying to make consistent use of tags (mysociety/whatdotheyknow-theme#1158, mysociety/whatdotheyknow-theme#1143, etc)

As a concrete example, I'd expect to see the tag poisoned with a counterpart note saying we use it when the "Body isn’t subject to FOI due to minority non-public sector owner(s)/member(s)".
@garethrees garethrees added x:uk enhancement Adds new functionality f:admin labels Apr 27, 2022
@garethrees garethrees mentioned this issue Apr 28, 2022
Closed
@garethrees garethrees added this to the Generalised Notes milestone Jun 21, 2022
@mysociety mysociety deleted a comment from FOIMonkey Jul 13, 2022
@gbp gbp self-assigned this Aug 2, 2022
@gbp gbp mentioned this issue Aug 3, 2022
Merged
gbp added a commit that referenced this issue Aug 10, 2022
@gbp
Add tagged notes
554a700 
Allow notes to be created with an association to tags via a
`Note#notable_tag` column.

This updates `Notable#all_notes` to combine concrete and tagged notes.

Fixes #6994
gbp added a commit that referenced this issue Aug 11, 2022
@gbp
Add tagged notes
fd28806 
Allow notes to be created with an association to tags via a
`Note#notable_tag` column.

This updates `Notable#all_notes` to combine concrete and tagged notes.

Fixes #6994
gbp added a commit that referenced this issue Aug 11, 2022
@gbp
Add tagged notes
22c0ecb 
Allow notes to be created with an association to tags via a
`Note#notable_tag` column.

This updates `Notable#all_notes` to combine concrete and tagged notes.

Fixes #6994
@gbp gbp mentioned this issue Aug 11, 2022
Merged
3 tasks
@gbp gbp closed this as completed in 1b19d18 Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbp gbp

Labels
enhancement Adds new functionality f:admin x:uk
Projects
None yet
Milestone
Generalised Notes
Development

Successfully merging a pull request may close this issue.

[#4478] New notes model and admin controller mysociety/alaveteli
2 participants
@gbp @garethrees