Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling PublicBody#expire_requests causes platform stability issue #7101

Closed
gbp opened this issue Jun 13, 2022 · 4 comments
Closed

Calling PublicBody#expire_requests causes platform stability issue #7101

gbp opened this issue Jun 13, 2022 · 4 comments
Labels
bug Breaks expected functionality f:redaction performance x:uk

Comments

@gbp
Copy link
Member

gbp commented Jun 13, 2022

Just had a issue where most of our WDTK passenger processes were tied up and weren't able to response to web traffic.

Which root cause is due to calling PublicBody#expire_requests

This happens for at least two (maybe more?) occasions.

  1. PublicBody#url_name is changed
  2. CensorRule applicable to a public body's requests is created/updated/destroyed

In absence of #1240 we should ensure this works without blocking the passenger processes.

Initial attempt at fixing this is at #6967

@RichardTaylor
Copy link

Noting that today's issue related to adding/editing a body-wide censor rule to a body with lots of requests - https://github.com/mysociety/whatdotheyknow-private/issues/20#issuecomment-1154038699

A previous similar feeling issue arose when renaming a set of authorities which had a reasonable number of requests made to them. This was in relation to name changes on Welsh County Councils. See mysociety/whatdotheyknow-theme#1131 and mysociety/whatdotheyknow-theme#1132

Perhaps the fix here will address the issue in both cases?

@garethrees
Copy link
Member

Noting that there's a bunch of different implementations for essentially the same thing across different models, so we should think about this from the point of view of coalescing them into a common Reindexable concern (#6931).

@garethrees
Copy link
Member

@gbp is this resolved by #1240?

@gbp
Copy link
Member Author

gbp commented Mar 28, 2023

Yes, this should all be fixed

@gbp gbp closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks expected functionality f:redaction performance x:uk
Projects
None yet
Development

No branches or pull requests

3 participants