Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercase characters in request email divert incoming message to holding pen #7902

Closed
garethrees opened this issue Sep 14, 2023 · 6 comments
Closed
Assignees
Labels
f:admin improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:uk

Comments

@garethrees
Copy link
Member

Here's a redacted but real example:

To: Request-[id]-[idhash]@Whatdotheyknow.Com
  • Uppercase R of Request
  • Uppercase W of Whatdotheyknow
  • Uppercase C of .Com

We should do a case-insensitive comparison of these parts.

@garethrees garethrees added the improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) label Sep 14, 2023
@alexander-griffen alexander-griffen self-assigned this Sep 21, 2023
@alexander-griffen
Copy link
Contributor

Writing tests expected to fail for this seem to pass, which implies that the issue may not be to do with cases (see attached PR)

@mdeuk
Copy link
Collaborator

mdeuk commented Sep 25, 2023

Writing tests expected to fail for this seem to pass, which implies that the issue may not be to do with cases (see attached PR)

Would it help to have a couple of the real world raw emails, to see if there's any less obvious "funky formatting" at play?

@gbp
Copy link
Member

gbp commented Sep 28, 2023

Would it help to have a couple of the real world raw emails, to see if there's any less obvious "funky formatting" at play?

Yes please @mdeuk, it would be good to verify the issue with real examples and try workout if case-insensitivity is the issue or maybe there is another cause.

@mdeuk
Copy link
Collaborator

mdeuk commented Sep 28, 2023

Yes please @mdeuk, it would be good to verify the issue with real examples and try workout if case-insensitivity is the issue or maybe there is another cause.

No problem - I'll send you across an email with a couple of links in a minute. 👍

@gbp
Copy link
Member

gbp commented Sep 29, 2023

Thanks @mdeuk for the examples, having gone through this I think I've gone and understanding of what is happening. Basically both the To and Received have the address, one mixed case one down case. We don't get an exact match to a single request because we don't unique the requests - we can fix this easily but writing a failing spec is proving difficult.

Wondering if this has actually been fixed by #7790 as the guess mechanism works slightly different and it does return unique requests, so since Monday when WDTK got deployed with single guess redelivery, have their been any more cases of this issue?

@gbp
Copy link
Member

gbp commented Oct 26, 2023

This is definitely not an issue now we are checking the Message-ID headers in #7913

@gbp gbp closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:admin improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:uk
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants