ci: Stop using prettier for formatting and linting

n8n-io · Jan 6, 2025 · e4469af · e4469af
1 parent 1b91000
commit e4469af
Show file tree

Hide file tree

Showing 14 changed files with 82 additions and 160 deletions.
diff --git a/.prettierrc.js b/.prettierrc.js
diff --git a/.vscode/extensions.json b/.vscode/extensions.json
@@ -5,7 +5,6 @@
 		"dangmai.workspace-default-settings",
 		"dbaeumer.vscode-eslint",
 		"EditorConfig.EditorConfig",
-		"esbenp.prettier-vscode",
 		"mjmlio.vscode-mjml",
 		"Vue.volar",
 		"vitest.explorer"

diff --git a/.vscode/settings.default.json b/.vscode/settings.default.json
@@ -1,5 +1,5 @@
 {
-	"editor.defaultFormatter": "esbenp.prettier-vscode",
+	"editor.defaultFormatter": "biomejs.biome",
 	"editor.formatOnSave": true,
 	"[javascript]": {
 		"editor.defaultFormatter": "biomejs.biome"
@@ -25,7 +25,6 @@
 	"typescript.format.enable": false,
 	"typescript.tsdk": "node_modules/typescript/lib",
 	"workspace-default-settings.runOnActivation": true,
-	"prettier.prettierPath": "node_modules/prettier/index.cjs",
 	"eslint.probe": ["javascript", "typescript", "vue"],
 	"eslint.workingDirectories": [
 		{

diff --git a/biome.jsonc b/biome.jsonc
@@ -6,6 +6,16 @@
 		"useIgnoreFile": true
 	},
 	"files": {
+		"include": [
+			"**/*.js",
+			"**/*.ts",
+			"**/*.json",
+			"**/*.vue",
+			"**/*.yml",
+			"**/*.md",
+			"**/*.css",
+			"**/*.scss"
+		],
 		"ignore": [
 			"**/.turbo",
 			"**/coverage",
@@ -22,11 +32,7 @@
 		"indentWidth": 2,
 		"lineEnding": "lf",
 		"lineWidth": 100,
-		"attributePosition": "auto",
-		"ignore": [
-			// Handled by prettier
-			"**/*.vue"
-		]
+		"attributePosition": "auto"
 	},
 	"organizeImports": { "enabled": false },
 	"linter": {
@@ -47,5 +53,18 @@
 			"quoteStyle": "single",
 			"attributePosition": "auto"
 		}
-	}
+	},
+	"overrides": [
+		{
+			"include": ["*.svelte", "*.astro", "*.vue"],
+			"linter": {
+				"rules": {
+					"style": {
+						"useConst": "off",
+						"useImportType": "off"
+					}
+				}
+			}
+		}
+	]
 }
diff --git a/lefthook.yml b/lefthook.yml
@@ -1,16 +1,9 @@
 pre-commit:
   commands:
     biome_check:
-      glob: 'packages/**/*.{js,ts,json}'
+      glob: 'packages/**/*.{js,ts,json,vue,yml,md,css,scss}'
       run: ./node_modules/.bin/biome check --write --no-errors-on-unmatched --files-ignore-unknown=true --colors=off {staged_files}
       stage_fixed: true
       skip:
         - merge
         - rebase
-    prettier_check:
-      glob: 'packages/**/*.{vue,yml,md,css,scss}'
-      run: ./node_modules/.bin/prettier --write --ignore-unknown --no-error-on-unmatched-pattern {staged_files}
-      stage_fixed: true
-      skip:
-        - merge
-        - rebase
diff --git a/package.json b/package.json
@@ -41,7 +41,7 @@
     "worker": "./packages/cli/bin/n8n worker"
   },
   "devDependencies": {
-    "@biomejs/biome": "^1.9.0",
+    "@biomejs/biome": "^1.9.4",
     "@n8n_io/eslint-config": "workspace:*",
     "@types/jest": "^29.5.3",
     "@types/node": "*",

diff --git a/packages/@n8n/chat/package.json b/packages/@n8n/chat/package.json
@@ -12,8 +12,8 @@
     "typecheck": "vue-tsc --noEmit",
     "lint": "eslint . --ext .js,.ts,.vue --quiet",
     "lintfix": "eslint . --ext .js,.ts,.vue --fix",
-    "format": "biome format --write src .storybook && prettier --write src/ --ignore-path ../../.prettierignore",
-    "format:check": "biome ci src .storybook && prettier --check src/ --ignore-path ../../.prettierignore",
+    "format": "biome format --write src .storybook",
+    "format:check": "biome ci src .storybook",
     "storybook": "storybook dev -p 6006 --no-open",
     "build:storybook": "storybook build"
   },

diff --git a/packages/@n8n_io/eslint-config/base.js b/packages/@n8n_io/eslint-config/base.js
@@ -60,13 +60,6 @@ const config = (module.exports = {
 		 * https://github.com/airbnb/javascript/tree/master/packages/eslint-config-airbnb-base/rules
 		 */
 		'eslint-config-airbnb-typescript/base',
-
-		/**
-		 * Config to disable ESLint rules covered by Prettier
-		 *
-		 * https://github.com/prettier/eslint-config-prettier
-		 */
-		'eslint-config-prettier',
 	],
 
 	rules: {
@@ -105,9 +98,10 @@ const config = (module.exports = {
 		/**
 		 * https://eslint.org/docs/latest/rules/indent
 		 *
-		 * Delegated to Prettier.
+		 * Delegated to Biome.
 		 */
 		indent: 'off',
+		'@typescript-eslint/indent': 'off',
 
 		/**
 		 * https://eslint.org/docs/latest/rules/no-constant-binary-expression

diff --git a/packages/@n8n_io/eslint-config/package.json b/packages/@n8n_io/eslint-config/package.json
@@ -9,7 +9,6 @@
     "@vue/eslint-config-typescript": "^13.0.0",
     "eslint": "^8.57.0",
     "eslint-config-airbnb-typescript": "^18.0.0",
-    "eslint-config-prettier": "^9.1.0",
     "eslint-import-resolver-typescript": "^3.6.1",
     "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-lodash": "^7.4.0",

diff --git a/packages/design-system/package.json b/packages/design-system/package.json
@@ -13,8 +13,8 @@
     "build:storybook": "storybook build",
     "storybook": "storybook dev -p 6006",
     "chromatic": "chromatic",
-    "format": "biome format --write .  && prettier --write . --ignore-path ../../.prettierignore",
-    "format:check": "biome ci .  && prettier --check . --ignore-path ../../.prettierignore",
+    "format": "biome format --write .",
+    "format:check": "biome ci .",
     "lint": "eslint src --ext .js,.ts,.vue --quiet",
     "lintfix": "eslint src --ext .js,.ts,.vue --fix"
   },

diff --git a/packages/editor-ui/package.json b/packages/editor-ui/package.json
@@ -11,8 +11,8 @@
     "dev": "pnpm serve",
     "lint": "eslint src --ext .js,.ts,.vue --quiet",
     "lintfix": "eslint src --ext .js,.ts,.vue --fix",
-    "format": "biome format --write . && prettier --write . --ignore-path ../../.prettierignore",
-    "format:check": "biome ci . && prettier --check . --ignore-path ../../.prettierignore",
+    "format": "biome format --write .",
+    "format:check": "biome ci .",
     "serve": "cross-env VUE_APP_URL_BASE_API=http://localhost:5678/ vite --host 0.0.0.0 --port 8080 dev",
     "test": "vitest run",
     "test:dev": "vitest --silent=false"

diff --git a/packages/workflow/test/ExpressionExtensions/ExpressionExtension.test.ts b/packages/workflow/test/ExpressionExtensions/ExpressionExtension.test.ts
@@ -158,11 +158,15 @@ describe('tmpl Expression Parser', () => {
 		});
 
 		test('Multiple optional chains in an expression', () => {
-			expect(extendTransform('$json.test?.test2($json.test?.test2)')?.code).toBe(`window.chainCancelToken2 = ((window.chainValue2 = $json.test) ?? undefined) === undefined, window.chainCancelToken2 === true ? undefined : window.chainValue2.test2(
+			expect(
+				extendTransform('$json.test?.test2($json.test?.test2)')?.code,
+			).toBe(`window.chainCancelToken2 = ((window.chainValue2 = $json.test) ?? undefined) === undefined, window.chainCancelToken2 === true ? undefined : window.chainValue2.test2(
   (window.chainCancelToken1 = ((window.chainValue1 = $json.test) ?? undefined) === undefined, window.chainCancelToken1 === true ? undefined : window.chainValue1.test2)
 );`);
 
-			expect(extendTransform('$json.test?.test2($json.test.sum?.())')?.code).toBe(`window.chainCancelToken2 = ((window.chainValue2 = $json.test) ?? undefined) === undefined, window.chainCancelToken2 === true ? undefined : window.chainValue2.test2(
+			expect(
+				extendTransform('$json.test?.test2($json.test.sum?.())')?.code,
+			).toBe(`window.chainCancelToken2 = ((window.chainValue2 = $json.test) ?? undefined) === undefined, window.chainCancelToken2 === true ? undefined : window.chainValue2.test2(
   (window.chainCancelToken1 = ((window.chainValue1 = extendOptional($json.test, "sum")) ?? undefined) === undefined, window.chainCancelToken1 === true ? undefined : window.chainValue1())
 );`);
 		});