Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.11? #7

Closed
jimmymathews opened this issue Jul 21, 2023 · 4 comments
Closed

Python 3.11? #7

jimmymathews opened this issue Jul 21, 2023 · 4 comments
Assignees
@CarlinLiao
Labels
enhancement New feature or request

Comments

@jimmymathews
Copy link

Is there anything holding this package back from support for Python 3.11, the most recent release?
@CarlinLiao
Copy link
Collaborator

The histocartography packages cggnn depends on assume the older Python version specified in the environment yaml.

Not strictly related to this, but squidpy appears to prefer 3.9 as well.

@CarlinLiao
Copy link
Collaborator

FYI type hints that don't require imports from the typing package like Optional or Union were added in python 3.11 only. Not having to import the capitalized List for hints was added in 3.9.

@CarlinLiao CarlinLiao closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2023
@CarlinLiao
Copy link
Collaborator

After pulling in the latest changes in histocartography and testing, I think I can remove the python 3.9 requirement pending a few further updates on my part.

These changes can be accelerated if SPT#185 is completed in a speedy fashion.

@CarlinLiao CarlinLiao reopened this Aug 15, 2023
@CarlinLiao CarlinLiao self-assigned this Aug 15, 2023
@CarlinLiao CarlinLiao added the enhancement New feature or request label Aug 15, 2023
@CarlinLiao
Copy link
Collaborator

Latest change bumps required version to 3.11. Almost certainly more strict than it needs to be, but we've been developing exclusively on 3.11 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarlinLiao CarlinLiao

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CarlinLiao @jimmymathews