Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Option "Use cache in case of an error" results in no events returned #137

Open
Programie opened this issue May 4, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Programie
Copy link

Programie commented May 4, 2022

Describe the bug
I've an "upcoming" node retrieving events from my Nextcloud calendars. Until today, I didn't enabled the option "Use cache in case of an error", so in case of an error no events are returned. This caused an issue today, so I enabled the option "Use cache in case of an error" from which I would expect that the node will simply return the previously successfully fetched events.

But in my case, whenever I enable the cache option, the node never returns any events.

To Reproduce
Steps to reproduce the behavior:

  1. Create a CalDAV calendar config and enable the cache option
  2. Add an upcoming node, select the CalDAV config, leave calendars empty, select "Events" as event types
  3. Connect the upcoming node to a debug node
  4. Trigger the upcoming node using a trigger node

Expected behavior
In case no error occurs, a list of events should be retrieved. In case of an error, the last successfully fetched data should be used.

Screenshots

First trigger with enabled cache, second trigger with disabled cache.

image

**node-red-contrib-ical-events

  • Version: 2.2.0
  • node-red version: v2.2.2
  • nodejs version: v14.18.2
  • is it an ical, caldav or icloud calendar? CalDAV (Nextcloud 23)
@Programie Programie added the bug Something isn't working label May 4, 2022
naimo84 added a commit that referenced this issue May 7, 2022
@naimo84
Copy link
Owner

naimo84 commented Jan 6, 2023

Oh sry, I've overseen this issue. I'll close it, because it should be already part of v2.2.1 😉

@naimo84 naimo84 closed this as completed Jan 6, 2023
@Programie
Copy link
Author

I just tested it with v2.2.1 but there are still no events returned if I enable "Use cache in case of an error".

I've also added an ical calendar (Google Calendar) and also enabled the option for that calendar and it is working in that case.

So, it looks like it's only broken for CalDAV.

@naimo84 naimo84 reopened this Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants