-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Namecoin-Qt 0.3.80 Manage Names tab to Namecoin Core #42
Comments
Thanks for raising this @JeremyRand . I posted the original namecoin-qt client bounty of 1000nmc that snailbrain and @coder partially collected when they produced their namecoin-qt branch (also became namecoinq branch under @phelixnmc). However, part of that bounty was rebasing namecoin-qt back onto the main namecoin branch updated on bitcoin's latest, and that never happened. So there remains 250nmc from that bounty which I would consider to be completed if Manage Names tab from namecoinq (0.3.80) was to be ported into the GUI produced by @domob1812 namecore rebase on bitcoin core (that I now consider to be the main namecoin branch). There is also the question then of on-going maintenance of namecore's namecoin-qt and if the Manage Names tab would add to that overhead. I could be convinced to add to the porting bounty if the participant were to be active maintaining namecoin-qt inside namecore, for at least 6-12 months, such that @domob1812 would not be negatively impacted or deterred from the great job he is doing at present. In fact, having another maintainer contributing to namecore would be a worthwhile goal in itself. |
Hi @randy-waterhouse , The port of the Manage Names tab has been merged to master branch. If you believe that the conditions of the bounty are satisfied, feel free to contact @brandonrobertz and @luke-jr to discuss paying out the bounty. |
Hi @JeremyRand , Done. |
…::Decrypt 4146a31 qt, wallet: Drop unused parameter in WalletModel::setWalletEncrypted (Hennadii Stepanov) f886a20 qt, wallet: Drop unused parameter in Wallet{Frame|View}::encryptWallet (Hennadii Stepanov) 6e95011 qt, wallet: Remove unused AskPassphraseDialog::Decrypt (Hennadii Stepanov) Pull request description: Grabbed from #42 with an additional commit. Fix #1. ACKs for top commit: MarcoFalke: ACK 4146a31 promag: Code review ACK 4146a31. Tree-SHA512: 6070d8995525af826ad972cf1b8988ff98af0528eef285a07ec7ba0e2e92a7a6173a19dc371de94d4b437fa10f7921166e45a081de6ed2f4306e6502aafc94ee
b5ef9be675 Merge #1: Merge changes from upstream 9e7f512430 Merge remote-tracking branch 'origin/master' into bitcoin-fork 1f85030246 Add support for ARM64 darwin (#43) 3bb959c982 Remove unnecessary reinterpret_cast (#42) 2e97ab26b1 Fix (unused) ReadUint64LE for BE machines (#41) 47b40d2209 Bump dependencies. (#40) ba74185625 Move CI to Visual Studio 2019. efa301a7e5 Allow different C/C++ standards when this is used as a subproject. cc6d71465e CMake: Use configure_package_config_file() git-subtree-dir: src/crc32c git-subtree-split: b5ef9be6755a2e61e2988bb238f13d1c0ee1fa0a
This issue is for figuring out what it would take to merge the Manage Names tab from the old Namecoin-Qt into Namecoin Core.
Relevant people:
@domob1812 maintains Namecoin Core and isn't fond of coding in Qt, so the code can't be a big burden for him.
@randy-waterhouse is potentially interested in funding a bounty for this. I'll let him describe details of the bounty amount, and the conditions for awarding the bounty.
@fsb4000 was awarded a bounty for GUI-related work a few months ago; I'm curious if you think you're qualified to work on this.
I think this is very important, because Bitcoin Core is one of the most active and secure Bitcoin clients, and it would be good to be able to reuse their GUI efforts as much as possible. At the same time, I don't want Domob to be bogged down in fixing Qt issues that he didn't volunteer for.
The text was updated successfully, but these errors were encountered: