Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Namecoin developer GPG pubkeys for Gitian use #81

Open
2 tasks
JeremyRand opened this issue Mar 25, 2016 · 7 comments
Open
2 tasks

Add Namecoin developer GPG pubkeys for Gitian use #81

JeremyRand opened this issue Mar 25, 2016 · 7 comments
Labels
meta Not so much an actual coding issue, but about making a decision or improving our process.
Milestone

Comments

@JeremyRand
Copy link
Member

From #namecoin-meeting:

Mar 06 19:43:47 <Jeremy_Rand>   Erkan_Yilmaz: Gitian has a nice signature system, so if you have the GPG pubkeys of the various developers, Gitian can automatically verify that the build is trustworthy and tell you who reproduced the hashes
Mar 06 19:44:17 <qpm>   freenode:<Erkan_Yilmaz> I see
Mar 06 19:44:19 <Jeremy_Rand>   Bitcoin has the GPG pubkeys of the Gitian signers in their repo; we should probably do so as well
Mar 06 19:45:07 <qpm>   freenode:<cassiniNMC> ACK
Mar 06 19:46:02 <Jeremy_Rand>   cassiniNMC: are you ACKing posting binaries when 1 dev has posted Gitian sigs, or are you ACKing putting GPG pubkeys of the devs in the GitHub repo?
Mar 06 19:46:27 <qpm>   freenode:<cassiniNMC> both
Mar 06 19:46:29 <Jeremy_Rand>   ok
Mar 06 19:46:54 <Jeremy_Rand>   sounds good

Details are briefly mentioned at https://github.com/namecoin/namecoin-core/blob/master/doc/release-process.md#verify-other-gitian-builders-signatures-to-your-own-optional .

The 4 Namecoin developers I'm aware of who use Gitian are me, @josephbisch, @jonasbits, and @midnightmagic . @ryancdotorg has also expressed interest in the past. Are you guys okay with adding your GPG pubkeys to the namecoin-core repo? (I guess midnight's is already there, since he does Gitian builds for Bitcoin.)

  • master branch
  • 0.12 branch
@JeremyRand JeremyRand added this to the nc0.12.0 milestone Mar 25, 2016
@midnightmagic
Copy link

ACK! All this sounds great to me! How can I help?

@josephbisch
Copy link
Member

I don't see why not.

@JeremyRand
Copy link
Member Author

Should we remove the Bitcoin developers' GPG keys from our repo, or have them coexist with ours? Seems kind of weird to keep keys of people who aren't involved in the project in our repo. However, since Luke-Jr did do Gitian builds of Namecoin Core for Eligius, I'd say that if we remove the Bitcoin developers' keys, Luke's key should remain. Opinions?

Also I checked; @midnightmagic 's key isn't in the Bitcoin repo.

@JeremyRand
Copy link
Member Author

Also tagging @brandonrobertz , the newest member of the Namecoin Gitian club.

@brandonrobertz
Copy link

I looked around and it seems fairly split between other coins. Litecoin keeps the bitcoin dev keys. Dogecoin has their own. I think it makes sense to leave folks who are even somewhat active and remove those we don't know or trust. $0.02

@JeremyRand
Copy link
Member Author

For anyone who isn't aware, the reason I haven't yet committed my PGP pubkey is because I'm intending to create new keys in an offline VM. This was delayed by DWS, but I'm most likely going to be able to create new keys in the next week or so. I hope I'm not blocking anyone's progress?

domob1812 added a commit to domob1812/namecoin-core that referenced this issue Jun 8, 2018
I added my key at the top of the list, where I think we should put
Namecoin developers' keys.  I left the Bitcoin developers in there for
now (see also namecoin#81).
@domob1812
Copy link

I've added my own key for now in #223. @JeremyRand, I think you have a new key by now - please create a PR adding it. (Others feel free as well.)

I'm happy to keep Bitcoin developers for now - but we can also remove everyone except Luke if others prefer that.

domob1812 added a commit to domob1812/namecoin-core that referenced this issue Jun 11, 2018
I added my key at the top of the list, where I think we should put
Namecoin developers' keys.  I left the Bitcoin developers in there for
now (see also namecoin#81).
domob1812 added a commit that referenced this issue Jun 11, 2018
aba314e Add my GPG key to the list of Gitian signing keys. (Daniel Kraft)

Pull request description:

  I added my key at the top of the list, where I think we should put Namecoin developers' keys.  I left the Bitcoin developers in there for now (see also #81).

Tree-SHA512: 0317794685bb2fb70a7fd5026cb669a4e63acfe95b4d366fc7426477ea852dbb96269b126848c2a6d03cd6b91269121bfbb87816cced433bf27bdba8ba7e9066
@domob1812 domob1812 added the meta Not so much an actual coding issue, but about making a decision or improving our process. label Jun 11, 2018
domob1812 added a commit that referenced this issue Aug 20, 2018
9ea2365 Gitian: Add OpenPGP fingerprint for Jeremy Rand. (JeremyRand)

Pull request description:

  Refs #81

Tree-SHA512: e8b3fb878f0520b3a957e40635624ca43a9584175519ade7b188d696ef9c2863f238b4733e67b7381111f6917a6a8318d4d143384625e2ba43a0670b956db9d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Not so much an actual coding issue, but about making a decision or improving our process.
Projects
None yet
Development

No branches or pull requests

5 participants