Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use Clerk for authentication #377

Closed
wants to merge 2 commits into from
Closed

feat: Use Clerk for authentication #377

wants to merge 2 commits into from

Conversation

evadecker
Copy link
Member

@evadecker evadecker commented Feb 5, 2025 •
edited
Loading

What changed?

Use Clerk for authentication. Resolves #367. Resolves #277. Resolves #287. Resolves #286. Resolves #145. Resolves #76.

Why?

See rationale in #367.

How was this change made?

  • Installed Clerk and related packages
  • Uninstalled Convex Auth and related packages
  • Removed all Convex Auth code, replaced with Clerk

How was this tested?

  • Need to test cases written in the issue.
  • Test signup and password reset. Test account deletion.
  • Improve AppSidebar design; reposition user settings.
  • Multiple rows are being created in Convex for each user; debug why.
  • Use custom components where possible
  • Make sure contributor guide is up-to-date and includes info about setting up Clerk

Anything else?

ʕ•́ᴥ•̀ʔっ♡

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 438639a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
namesake Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file frontend CSS, HTML, and JS changes backend Schema, query, and mutation changes testing Unit and e2e tests labels Feb 5, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 5, 2025 •
edited
Loading

Deploying namesake with  Cloudflare Pages  Cloudflare Pages

Latest commit: 438639a
Status: ✅  Deploy successful!
Preview URL: https://a599d3ff.namesake-639.pages.dev
Branch Preview URL: https://clerk.namesake-639.pages.dev

View logs

@evadecker evadecker added this to the Namesake v1.0 milestone Feb 5, 2025
focus-stefano
focus-stefano previously approved these changes Feb 8, 2025
View reviewed changes
@evadecker evadecker dismissed focus-stefano’s stale review February 8, 2025 14:57

Invalid review, non-contributor

@evadecker
Copy link
Member Author

After exploration, sticking with Convex Auth. See rationale in #367.

@evadecker evadecker closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@focus-stefano focus-stefano focus-stefano left review comments

Assignees
No one assigned
Labels
backend Schema, query, and mutation changes dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation frontend CSS, HTML, and JS changes testing Unit and e2e tests
Projects
None yet
Milestone
Namesake v1.0
2 participants
@evadecker @focus-stefano