Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing Read Usage in DMR #378

Open
maceyslota opened this issue Feb 20, 2025 · 2 comments
Open

Increasing Read Usage in DMR #378

maceyslota opened this issue Feb 20, 2025 · 2 comments
Labels
question Looking for clarification on inputs and/or outputs

Comments

@maceyslota
Copy link

Hello,

I am wanting to see if it is possible to use more than the 300 read limit hard coded into the DMR command? Or, if there is a particular reason for the 300 read limit. I am looking for some potentially rare events and feel that 300 reads isn't capturing enough information. This is the error I get when I try to increase the max coverage to 300k reads:

calculated max coverage 300000 is greater than maximum allowed (300), setting to 300

Thanks!

@ArtRand
Copy link
Contributor

ArtRand commented Feb 20, 2025

Hello @maceyslota,

Let me look into it. The limit is due to the MAP-based p-value becoming unstable if you have very high coverages (as the p-value becomes zero). I'm sure I could add an option that removes the limit and disables the MAP-based p-value calculation - would that get you what you need? You would still get the score, effect, size, measurements of methylation etc.

@ArtRand ArtRand added the question Looking for clarification on inputs and/or outputs label Feb 20, 2025
@maceyslota
Copy link
Author

maceyslota commented Feb 20, 2025

Thanks for your response @ArtRand . I think the approach you described could be informative for the research question I am addressing. Thank you for offer to implement this change. Please let me know when you update it and how to use the options.

Do you think a different statistical test or model could be used to assess modification changes with higher coverages? If so, is this something that could be implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Looking for clarification on inputs and/or outputs
Projects
None yet
Development

No branches or pull requests

2 participants