Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binaries checked into repo #164

Open
jeffkaufman opened this issue Jan 28, 2025 · 0 comments
Open

Binaries checked into repo #164

jeffkaufman opened this issue Jan 28, 2025 · 0 comments

Comments

@jeffkaufman
Copy link
Member

There are a few binary files checked into the repo. This is not best practice, since it slows down git and diffs don't work well. I see:

  • ref/contaminants.fasta.gz
    • this is by far the biggest, and the only one that's really a problem
  • readme-workflow-diagram.png
    • I don't know how the diagram is made, but if it has a source much better to check that in
    • The diagram itself could be served from data.securebio.org
  • modules/local/countAlignmentDuplicates/resources/usr/bin/find_duplicates
    • also modules/local/countAlignmentDuplicates/find_duplicates/target/release/find_duplicates
    • you generally shouldn't check out
  • test-data/gold-standard-results/*.tsv.gz and test-data/toy-data/*.gz
    • better to have as raw tsv instead of compressing so that deltas can be reviewed
    • if you're testing code that consumes gzipped files, add a little wrapper that gzips as part of the test
    • these aren't big
@naobservatory naobservatory deleted a comment from Intelli-tech1 Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant