Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-ordered output due to missing mirror_step variable #198

Closed
ank1m opened this issue May 23, 2024 · 2 comments · Fixed by #221
Closed

Un-ordered output due to missing mirror_step variable #198

ank1m opened this issue May 23, 2024 · 2 comments · Fixed by #221
Labels
bug Something isn't working

Comments

@ank1m
Copy link
Collaborator

ank1m commented May 23, 2024

Issue:

StitchEE uses mirror_step variable to sort granules but l2ss removes mirror_step from the output when variable subsetting is requested.

Solutions:

  • Request l2ss to always include mirror_step and xtrack, similarly to longitude and latitude logic:
    • Cons: also makes this approach very TEMPO specific
  • Request EDS client to revise their variable subsetting interface by removing non-optional variables from selection and pass Harmony requests always including these variables:
    • Cons: direct access to Harmony API or via harmony-py would still allow user to remove non-optional variables
  • Discuss other solutions: creating additional flag for non-optional variables to be passed by Harmony to the services?

Workaround

  • Use longitude, filename or time to sort granules
@chris-durbin
Copy link
Collaborator

There's a concept of 'coordinate' variables that the L2SS team asked for a couple years ago (HARMONY-1121). I'd check with them if they keep all of the coordinate variables in the output file when they perform variable subsetting. If so that could be another solution - define mirror_step and xtrack as coordinate variables in UMM-Var.

@danielfromearth danielfromearth added the bug Something isn't working label Jun 24, 2024
@danielfromearth danielfromearth linked a pull request Jul 2, 2024 that will close this issue
4 tasks
@danielfromearth
Copy link
Collaborator

We are now ordering the files by time. It's not the ideal solution, but closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants