Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PersistentSet methods don't quite match underlying set methods #4

Open
pfw opened this issue Sep 27, 2018 · 1 comment
Open

PersistentSet methods don't quite match underlying set methods #4

pfw opened this issue Sep 27, 2018 · 1 comment

Comments

@pfw
Copy link
Contributor

pfw commented Sep 27, 2018

eg:

PersistentSet is

def union(self, other):

whilst the underlying set is:

def union(self, *others):

Is that a conscious choice or just an oversight? If an oversight I can make a PR if you'd like.
@nascheme nascheme mentioned this issue Oct 1, 2024
Open
@nascheme
Copy link
Owner

nascheme commented Oct 1, 2024

It was an oversight, I made a PR if you could review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pfw @nascheme