New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Found and fixed issue when using setRating option #51

Open

arunsharma82 opened this issue Sep 9, 2020 · 1 comment

arunsharma82 commented Sep 9, 2020

Found a bug in the JS file while using setRating option, the color was reseting back to crimson.

Issue found in lines 178 - 179 lines of full JS file, where wrong settings variable used.

Old code:
if (s.ratedColors && s.ratedColors.length && s.ratedColors[ratedColorsIndex]) {
ratedColor = s.ratedColors[ratedColorsIndex];

Fixed code:
if (s.ratedColor && s.ratedColor.length && s.ratedColor[ratedColorsIndex]) {
ratedColor = s.ratedColor[ratedColorsIndex];

mix1981 mentioned this issue

Decrease rank not visible but rank changed #52

Closed

SigsiuTrinity commented Apr 22, 2022

if you index s.ratedColor[ratedColorsIndex] you will get 'c', 'r', 'i', 'm', 's' or 'o' (depending on the index) for ratedColor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment