You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am seeing the code in NatsConnection class. when any exception occured we are simply returning null and not printing the logs. Due to that People don't know what happened when. It is a black box for every one who is using and who is supporting.
I would be great if we print any exception occured in the logs. Depending the Log level people can trace what happened in the Nats client.
Message requestInternal(String subject, Headers headers, byte[] data, Duration timeout, NatsRequestCompletableFuture.CancelAction cancelAction, boolean validateSubRep) throws InterruptedException {
CompletableFuture<Message> incoming = this.requestFutureInternal(subject, headers, data, timeout, cancelAction, validateSubRep);
try {
return (Message)incoming.get(timeout.toNanos(), TimeUnit.NANOSECONDS);
} catch (ExecutionException | CancellationException | TimeoutException var9) {
return null;
}
}
### Use case
It is easy to debug the issues.
### Contribution
Yes, I am ready to contribe for this, Is there any document to understand how this client interact with Nats server.
The text was updated successfully, but these errors were encountered:
I suppose we could add a call to the error listener, maybe a new method with a default implementation. The problem here is the client really doesn't care why there is an error, it's a failure and it needs to move forward. And I wonder if it will actually be more confusing, like why am I getting this error. I'll think on it.
@scottf In my opinion, Client should move forward if any failure at server but we should intimate as warning or info regarding that failure. This issue I have raised because there is connect timeout or unable to connect issue is happening only certain pods we want to debug why only certain pods were getting. Due to no logging we were not able to understand anything what is the issue.
Proposed change
I am seeing the code in NatsConnection class. when any exception occured we are simply returning null and not printing the logs. Due to that People don't know what happened when. It is a black box for every one who is using and who is supporting.
I would be great if we print any exception occured in the logs. Depending the Log level people can trace what happened in the Nats client.
The text was updated successfully, but these errors were encountered: