Fix setting empty IP when cannot fetch. Add log levels. Add custom IP check URL #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michnovka Thanks for the contribution. This PR contains one fix (handling empty IP), one new feature (custom URL to get pub IP) and one document change. Lets break it down and create separate PRs for each. |
|
@navilg I am sorry but I currently have no time to do that :\ |
|
Okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
And many other improvements:
Log levels - I added DEBUG log level, and introduced log_level variable which limits output to logs
Custom IP Check URL - if supplied, the URL will be fetched before the default 2 endpoints. Response just must have JSON reply with 'ip' field
minor fixes