Skip to content

Commit

Permalink
back to file streaming as default (prob memleakfix)
Browse files Browse the repository at this point in the history
  • Loading branch information
naxan6 committed Oct 6, 2024
1 parent bb88484 commit 5caf6d8
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions FKala.Core/KalaQl/Op_BaseQuery.cs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ public override bool CanExecute(KalaQlContext context)

public override void Execute(KalaQlContext context)
{
var result = context.DataLayer.LoadData(this.Measurement, this.StartTime, this.EndTime, CacheResolution, NewestOnly, context, DontInvalidateCache_ForUseWhileCacheRebuild).ToList();
//in-mem copy probably mem-leak
//var result = context.DataLayer.LoadData(this.Measurement, this.StartTime, this.EndTime, CacheResolution, NewestOnly, context, DontInvalidateCache_ForUseWhileCacheRebuild).ToList();

context.IntermediateDatasources.Add(
new ResultPromise()
Expand All @@ -49,11 +50,11 @@ public override void Execute(KalaQlContext context)
ResultsetFactory = () =>
{
// source file streaming
//var result = context.DataLayer.LoadData(this.Measurement, this.StartTime, this.EndTime, CacheResolution, NewestOnly, context, DontInvalidateCache_ForUseWhileCacheRebuild);
//return result;
var result = context.DataLayer.LoadData(this.Measurement, this.StartTime, this.EndTime, CacheResolution, NewestOnly, context, DontInvalidateCache_ForUseWhileCacheRebuild);
return result;

//in-mem copy
return Clone(result);
//in-mem copy probably mem-leak
//return Clone(result);
}
});
this.hasExecuted = true;
Expand Down

0 comments on commit 5caf6d8

Please sign in to comment.