Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

[UX Improvement] Opening channel details #25

Open
Darth-Coin opened this issue Nov 26, 2022 · 2 comments
Open

[UX Improvement] Opening channel details #25

Darth-Coin opened this issue Nov 26, 2022 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Darth-Coin
Copy link

Darth-Coin commented Nov 26, 2022

NOTE: _@fiatjaf this is just a proposal, no rush or bug, is just an observation to improve the noob experience with OBW.
So please before closing it, think about.
EDIT: Maybe is a bug, in the end. after 12h waiting for mempool to clear up, the tx is not confirmed but the channel is still in pending.
The peer confirmed also that have the channel in pending but no tx confirmed. Weird.
image

Description

Add more details in the opening channel procedure.

Actual behavior

The onchain balance remain the same after the channel opening is initiated and also the sats for the new channel are reflected into LN balance (and is not right).
obw

Expected behavior

The sats from onchain should be gone, or at least in the brackets or other color, to indicate that are in pending or something.
Or make the onchain balance 0 (was sent all sats available) but add in LN balance, in the brackets the opening channel amount, next to the real LN balance.
I don't know how you can fit into that small space, but at least inform the user that those funds are STILL NOT available.

Notes

  • I funded the opening channel with a quite low fee under the mempool recommended (testing), 5sat/vB, when low priority was 25 sat. That could explain why the tx it doesn't appear yet in mempool and/or in OBW tx log
  • So I kept OBW open for a while
  • I don't know whata new user of OBW should do in such a case. There's no other instruction in the app.

This is what I get when I click on pending channel:
Channel details
Remote peer node ID
03bf5f69adc41b4757e2ee88840f167398f4ab3a619fa73b7b25491f6ef349ea16
Local wallet node ID
03d3bd0165b830486b697e76d01a1fb1db30de3c114c43536342bb7abec59b0b7e
Channel short ID
unknown
Funding txid
91d01018593d3b8e1f626b9d3537ef0039e72d049f3968689852292bab098bd0
Channel started
26 Nov 2022

As old tester for wallets, I understand what is going on, but a newbie that will install first time OBW will not know that will have to wait and will do crazy things and/or complain where his sats...

@Darth-Coin Darth-Coin changed the title [UX Improvement] Opening channel details [Bug + UX Improvement] Opening channel details Nov 27, 2022
@Eternumkr
Copy link

Eternumkr commented Nov 27, 2022

LND side of thing just shows,

{
    "total_limbo_balance": "0",
    "pending_open_channels": [
        {
            "channel": {
                "remote_node_pub": "03d3bd0165b830486b697e76d01a1fb1db30de3c114c43536342bb7abec59b0b7e",
                "channel_point": "91d01018593d3b8e1f626b9d3537ef0039e72d049f3968689852292bab098bd0:0",
                "capacity": "304394",
                "local_balance": "0",
                "remote_balance": "301046",
                "local_chan_reserve_sat": "354",
                "remote_chan_reserve_sat": "3043",
                "initiator": "INITIATOR_REMOTE",
                "commitment_type": "STATIC_REMOTE_KEY",
                "num_forwarding_packages": "0",
                "chan_status_flags": "",
                "private": true
            },
            "commit_fee": "3348",
            "commit_weight": "552",
            "fee_per_kw": "4625"
        }

@Darth-Coin
Copy link
Author

Darth-Coin commented Nov 27, 2022

OK, we've tried again and seems that is working.

Remote peer node ID
03bf5f69adc41b4757e2ee88840f167398f4ab3a619fa73b7b25491f6ef349ea16
Local wallet node ID
03d3bd0165b830486b697e76d01a1fb1db30de3c114c43536342bb7abec59b0b7e
Channel short ID
unknown
Funding txid
208c317fb0158e65b03563e66250b3854888c14c565b250bc4b26490fb6036e5
Channel started
4 minutes ago

Now the funds are taken from onchain and appeared the tx in logs.
photo_2022-11-27_10-27-17

But the displayed balance in LN is still wrong.
Maybe was just due to mempool too busy and the tx was rejected by miners being too low.

Now channel is opening normally, will try to close the previous one, to see what happen.
Like in this amazing theory of everything: for more you fuck around, more you find out :)

So fucking around more, to find out more, I click on force close the pending channel, just to see what happen.
Will wait to see when will be eliminated from there, having nothing to close.

image

After I initiated the FC for the old pending channel, the pending sats disappeared from LN balance (is correct) but I have this sign on top right, I don't know what represent. Also the FC tx appear like pending, with those 300k sats that are from nowhere.

image

This is nice warning for the user

image

@Darth-Coin Darth-Coin changed the title [Bug + UX Improvement] Opening channel details [UX Improvement] Opening channel details Nov 27, 2022
@Gravity2106 Gravity2106 added bug Something isn't working enhancement New feature or request labels Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants