-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off Data Dashboard in production #47
Comments
FYI @milen-sage - we hare having some issues with the Data Dashboard in production. When working the dashboard looks great but I think we should hold it to launch at a steering committee or similar once fixed, and update our FAQ docs on how to use/interpret at the same time |
Confirming that we are going to revert per the PR above |
|
@adamjtaylor I can confirm that reverting to codebase in the |
@milen-sage we just completed the actions above. I can confirm that production looks ok again. |
@adamjtaylor and @elv-sb could you start gh issues for the bugs/features you'd like to see with the dashboard (aside from docs - we are planning on that work)? Thanks! |
@milen-sage we can add those during our next sprint. Thank you! |
Thanks @elv-sb! Meanwhile feel free to explore more of the dashboard in the testing HTAN instance. Once we finish the docs on how schema validation rules are reflected in the dashboard and how the dashboard results can be interpreted we can have a dashboard exploration/play meeting. But certainly agreed with you and @adamjtaylor that we don't want to scare centers, if they see a bunch of their metadata, clinical and biospecimen data are marked as invalid out of the blue. |
Bring to next data with FAIR on 12/12 What is the plan at the end of this sprint?
|
Per discussion with Milen on 1/9 HTAN/FAIR stakeholder call: Adam: Ability to toggle dashboard - is this being considered? |
@adamjtaylor the dashboard has been disabled by default in the main branch of DCA and release v23.1.1. One note: you'll need to incorporate the changes in shinyapps_deploy.yml . The step |
I'd like to be able to update our DCA to v23.1.1, but when I try and open a PR for this it won't allow me |
Following @milen-sage's comment in FAIR Data sprint review we should actually update to v23.1.2 (ie level with the head repo main branch) as the Google auth changes are included in the newest version. |
Moving to ready for review as the Data Dashboard (Not DCA!) is off. Suggest we have a new issue for the cleanup and actually getting to the latest DCA version. |
@adamjtaylor why is the DCA off? Based on discussion with @afwillia and the jira issue, I had assumed the DCA was running w/ updated schematic code (v23.1.1) and DCA v22.11.x, which would have switched to updated Google auth mechanism, even if not using the latest DCA version. I was assuming @afwillia was syncing up with @adamjtaylor to update the DCA to v23.1.3 to move on to the latest version but that was not a blocker for DCA running, based on conversation with @afwillia. Was my understanding incorrect? Or is there a different issue? |
@milen-sage Typo on my behalf. Data dashboard is currently off - not the DCA. Have updated comment. |
our update to https://github.com/Sage-Bionetworks/data_curator/releases/tag/v22.11.3 turns on the data dashboard.
I imagine this will result in quite a few questions from centers about data completeness. I have some already.
I would like to explore the possibility of hiding the data daashboard in production until there is appropriate documentation for centers and we can properly launch the feature at a steering committee.
I would like to remove ASAP and then target adding back in during the 23/01 sprint.
The text was updated successfully, but these errors were encountered: