Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node version in actions #414

Closed
adamjtaylor opened this issue May 30, 2024 · 4 comments · Fixed by #421
Closed

Update Node version in actions #414

adamjtaylor opened this issue May 30, 2024 · 4 comments · Fixed by #421
Assignees

Comments

@adamjtaylor
Copy link
Contributor

adamjtaylor commented May 30, 2024

Check attributes are unique
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check component requirements
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check attributes exist
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check attributes are used
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
@aclayton555
Copy link
Contributor

aclayton555 commented Jun 6, 2024

Consider pining these to run on latest, rather than a specific version. Also consider a better testing process (and backlog a ticket for this).

@adamjtaylor
Copy link
Contributor Author

Better testing process can be covered in the existing #416

@jmvera255
Copy link
Contributor

jmvera255 commented Jun 10, 2024

I'm documenting all Node.js 16 warning for all GH action runs:

schema-bq.yml

  • actions/checkout@v2 --> actions/checkout@v4
  • actions/setup-python@v4 --> actions/setup-python@v5
  • google-github-actions/auth@v1 --> google-github-actions/auth@v2
  • google-github-actions/setup-gcloud@v1 --> google-github-actions/setup-gcloud@v2

ci-lint-validate-convert.yml

  • actions/checkout@v3 --> actions/checkout@v4
  • actions/setup-python@v4 --> actions/setup-python@v5

model-integrity-checks.yml

  • actions/checkout@v3 --> actions/checkout@v4
  • actions/setup-python@v4 --> actions/setup-python@v5

@jmvera255
Copy link
Contributor

Consider pining these to run on latest, rather than a specific version.

@adamjtaylor I did some reading at it sounds like actions need to be pinned either to a specific tag or a branch and it's up to the developers to create and maintain a "latest" branch/tag. I'm not seeing "latest" as a tag or branch either setup-python or checkout which makes me think I'm not likely to find "latest" for other actions list above.

For reference: https://github.com/marketplace/actions/latest-tag

I will move forward with updating actions to the latest available version tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants