Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not create VGs or PVs #2

Open
andylytical opened this issue Aug 31, 2022 · 2 comments
Open

Does not create VGs or PVs #2

andylytical opened this issue Aug 31, 2022 · 2 comments

Comments

@andylytical
Copy link
Member

Suggest a better approach is to have a volume_groups parameter that can be processed in the exact same manner as https://github.com/puppetlabs/puppetlabs-lvm/blob/master/manifests/init.pp. This will create the PVs and VGs if they don't already exist.

@andylytical
Copy link
Member Author

A possibly simpler solution is to accept a parameter of volumes that will likewise ensure that PVs and VGs are created if necessary.

@jakerundall
Copy link
Contributor

Whatever we do, let's not require users to manage VGs and PVs, i.e., let's make sure that is optional. So I guess it makes more sense to me to implement a volumes parameter or a volume_groups separate from the existing lvs parameter; certainly would not want to replace the lvs parameter with a volume_groups parameter (which, again, exists in the underlying lvm module).

NOTE: The point of profile_lvm was to do things that the lvm module doesn't do, namely install required packages and handle bind mounts. Strictly speaking it doesn't seem necessary that profile_lvm would need to accept input about VGs or PVs (or, for that matter, LVs). But I can see that it might be more convenient to have it accept this data (and pass it to lvm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants