You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Whatever we do, let's not require users to manage VGs and PVs, i.e., let's make sure that is optional. So I guess it makes more sense to me to implement a volumes parameter or a volume_groups separate from the existing lvs parameter; certainly would not want to replace the lvs parameter with a volume_groups parameter (which, again, exists in the underlying lvm module).
NOTE: The point of profile_lvm was to do things that the lvm module doesn't do, namely install required packages and handle bind mounts. Strictly speaking it doesn't seem necessary that profile_lvm would need to accept input about VGs or PVs (or, for that matter, LVs). But I can see that it might be more convenient to have it accept this data (and pass it to lvm).
Suggest a better approach is to have a
volume_groups
parameter that can be processed in the exact same manner as https://github.com/puppetlabs/puppetlabs-lvm/blob/master/manifests/init.pp. This will create the PVs and VGs if they don't already exist.The text was updated successfully, but these errors were encountered: