Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchOSD and related functions should return series names in title case #95

Closed
dylanbeaudette opened this issue Mar 1, 2019 · 2 comments
Labels
SoilWeb Related to the SoilWeb / UCDavis LAWR servers, Henry Mount DB, backend functionality and public API

Comments

@dylanbeaudette
Copy link
Member

tools::toTitleCase

Possibly change the API:
https://stackoverflow.com/questions/6176057/convert-all-records-in-postgres-to-titlecase-first-letter-uppercase

@brownag brownag added the SoilWeb Related to the SoilWeb / UCDavis LAWR servers, Henry Mount DB, backend functionality and public API label Jun 2, 2021
@brownag
Copy link
Member

brownag commented Jul 23, 2021

get_OSD() and the SoilKnowledgeBase OSD JSON files also return series names in all caps. I added a TODO to switch series names to title case. (ncss-tech/SoilKnowledgeBase#25; see for example https://github.com/ncss-tech/SoilKnowledgeBase/blob/main/inst/extdata/OSD/E/ECKRANT.json)

However this change strikes me as something that could wind up causing problems with backward compatibility. I am pretty used to these returning series name in all caps. And the file names are in all caps.

@dylanbeaudette
Copy link
Member Author

Yeah, I'm not sure about the original justification. There are so many example of using upper case that broad-scale conversion to title case isn't warranted. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SoilWeb Related to the SoilWeb / UCDavis LAWR servers, Henry Mount DB, backend functionality and public API
Projects
None yet
Development

No branches or pull requests

2 participants