Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NumPy 1.7 C API #27

Open
stefanseefeld opened this issue May 4, 2013 · 3 comments
Open

Support NumPy 1.7 C API #27

stefanseefeld opened this issue May 4, 2013 · 3 comments

Comments

@stefanseefeld
Copy link
Contributor

Building Boost.NumPy against current NumPy versions results in deprecation warnings, as it depends on an outdated API.
It would be great to migrate to the new NumPy API.

@GongYiLiao
Copy link

NumPy 1.7 C API wraps up everything, deprecates direct access.

@TallJimbo
Copy link
Member

Right. We'll have to do more than just eliminate the warnings here to be safe for future NumPy versions, as I don't believe there are deprecation warnings on direct access, even though it has also been deprecated.

So this is actually a duplicate of #8, but I think I'll close that one and keep this one open, as it contains a better description of the issue (I opened #8 before it was clear exactly what NumPy 1.7 was going to do to the API, or at least before I knew enough about it).

That said, I'm not in a huge rush to do this, as I think it's important to support the old API for quite a while yet, and supporting both APIs just means that we'd have to duplicate here all the #define-based infrastructure that's already in NumPy itself in order to support both. It's clearly worth doing eventually, and I'll gladly accept patches or pull requests that move us in that direction, but I may not get to it myself for a while yet.

@TallJimbo
Copy link
Member

TallJimbo commented Jun 27, 2016

Looks like all we're using from the deprecated API are the old versions of the various NPY_* (now NPY_ARRAY_*) defines that were perhaps gratuitously changed in numpy 1.7. Updating that is trivial, but will break support for NumPy versions < 1.7. If anyone paying close attention would be hurt by that, speak now or forever hold your peace: I could also just disable the warnings without moving to the new API, but that just punts the problem down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants