-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
are there plans to support eslint 9? #147
Comments
coc-eslint already supports ESLint 9, you need to install eslint to your project. |
i have eslint installed in my project, the problem is that when i use eslint < 9 with local json config file ".eslintrc.json", coc-eslint correctly find the rules specified in the config and take them into account, but when I simply upgrade project to eslint 9 and use its new config (which, as I understand it, must be in the js file), coc-eslint stops taking into account any rules specified in the new config. Perhaps because he does not understand that he needs to use this config file? but with the previous version it found the config file itself (I do not specify it somewhere on my own) |
Enable |
I enabled eslint.experimental.useFlatConfig, but without success.
but no errors in vim. I see no errors when :CocOpenLogs
How can I troubleshoot it? |
Solved by removing package.json from the parent folder. |
One substantial inconvenience of |
@ravicious one solution is to use |
Instead of checking it it, I've added |
Right, but in the case that I described this is no different than just adjusting the global config. If you don't commit the local config to git (which I suppose you almost never want to do), then all release branches and trunk use the same coc settings, no matter whether the actual branch you're on has ESLint 9 or not. |
Right, if you have branches with different versions it's definitely a problem. I forgot that you wrote about that. It looks like the current implementation was pulled from an early version of the eslint 9 support in vscode-eslint. That extension now has support for automatically detecting if flat config should be used or not, so one could probably look at what that is doing. |
No description provided.
The text was updated successfully, but these errors were encountered: