Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add code style and linter support for neon-cli subproject #496

Open
amilajack opened this issue Feb 28, 2020 · 1 comment
Open

add code style and linter support for neon-cli subproject #496

amilajack opened this issue Feb 28, 2020 · 1 comment
Labels
beginner friendly CI requires javascript

Comments

@amilajack
Copy link
Member

amilajack commented Feb 28, 2020 •
edited
Loading

Inspired by #388 (comment)

Main rules:

  • prefer let over var declarations
  • two spaces for indentation
  • double quotes

Prettier is a great option for code styling and ESlint is a great option now (over TSLint, which is now deprecated). ESLint now has full support for TypeScript with a wide array of rules that cater to TypeScript specifically.

Would love feedback on these suggestions!
@dherman
Copy link
Collaborator

dherman commented Mar 13, 2020

These sound good to me! If you want to submit a PR I'll be happy to review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly CI requires javascript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dherman @kjvalencik @amilajack