Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porch-controllers is not defining any rights for porch repositories and does not defined watch rights #588

Closed
nagygergo opened this issue Apr 3, 2024 · 3 comments
Assignees
Labels
area/platform area/porch Porch related issues
Milestone

Comments

@nagygergo
Copy link

The controller-runtime's caching client is setting up watches by default for repositories and for the wildcard resources used by packagevariantSet controller. The defined rbac configuration is requesting rights to watch resources.

//+kubebuilder:rbac:groups=,resources=,verbs=list

Also, as a side improvement, it would be good to call out that the packageVariantSet controller requires get/list/watch rights for repository resources in the rbac configurations

@gvbalaji gvbalaji added this to R4 Apr 3, 2024
@gvbalaji gvbalaji moved this to Todo in R4 Apr 3, 2024
@gvbalaji gvbalaji added this to the R3 milestone Apr 3, 2024
@efiacor efiacor added the area/porch Porch related issues label May 14, 2024
@kushnaidu
Copy link
Contributor

PR created - nephio-project/porch#56

@kushnaidu kushnaidu self-assigned this May 24, 2024
@kushnaidu kushnaidu moved this from Todo to In Progress in R4 May 24, 2024
@kushnaidu kushnaidu removed their assignment Jun 5, 2024
@kushnaidu kushnaidu moved this from In Progress to Todo in R4 Jun 5, 2024
@kushnaidu kushnaidu self-assigned this Jun 5, 2024
@kushnaidu kushnaidu moved this from Todo to In Progress in R4 Jun 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in R4 Jun 5, 2024
@kushnaidu
Copy link
Contributor

kushnaidu commented Jun 5, 2024

Code is merged, Issue is not seen after the merge.

Waiting for Catalog repo changes to be merged - nephio-project/catalog#37

@kushnaidu kushnaidu moved this from Done to In Progress in R4 Jun 5, 2024
@kushnaidu kushnaidu reopened this Jun 5, 2024
@kushnaidu
Copy link
Contributor

PR merged, closing the ticket.

@github-project-automation github-project-automation bot moved this from In Progress to Done in R4 Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform area/porch Porch related issues
Projects
Status: Done
Development

No branches or pull requests

4 participants