Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph is not updated immediately when a TlcErrData::ChannelFailed is sent from a peer #407

Open
contrun opened this issue Dec 20, 2024 · 0 comments
Open

Graph is not updated immediately when a TlcErrData::ChannelFailed is sent from a peer #407

contrun opened this issue Dec 20, 2024 · 0 comments

Comments

@contrun
Copy link
Collaborator

contrun commented Dec 20, 2024

The processing of TlcErrData::ChannelFailed https://github.com/contrun/fiber/blob/c583ac8d6f5d7b7c2d7278eb80e391b66e9d0557/src/fiber/network.rs#L1487-L1495 is asynchronous. But we want to update the graph synchronously because the same payment session may be retried a few times immediately. We need to use the ChannelUpdate message from TlcErrData::ChannelFailed to update the graph.
@doitian doitian moved this to 🔖 Ready in CKB Kanban Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
CKB Kanban
Status: 🔖 Ready
Milestone
No milestone
Development

No branches or pull requests
1 participant
@contrun