Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querying missing gossip messages is not very robost #408

Open
contrun opened this issue Dec 20, 2024 · 0 comments
Open

Querying missing gossip messages is not very robost #408

contrun opened this issue Dec 20, 2024 · 0 comments

Comments

@contrun
Copy link
Collaborator

contrun commented Dec 20, 2024

There are some scenarios where we have to resort to QueryBroadcastMessages to obtain more complete gossip messages. One is the dissemination of our own public channel information to the counter-party. Since normal broadcast requires the other party to send us a BroadcastMessageFilter (without this we will not send any thing to the peer), and the counterparty may have not sent this message to us, we can't reliably depend on normal broadcast mechanism to broadcast the message to counter-party. We can use QueryBroadcastMessages in this scenario.

But currently the querying of broadcast messages is a one-shot process. https://github.com/contrun/fiber/blob/c583ac8d6f5d7b7c2d7278eb80e391b66e9d0557/src/fiber/gossip.rs#L2438-L2440 This is not very reliable. The other party may not be ready to process this query (it does not have the message or in the above example, it may not be able to generate a ChannelUpdate yet because to it the funding transaction is not confirmed yet). We should at least retry a few more nodes a few more times before giving up.

@doitian doitian moved this to 🔖 Ready in CKB Kanban Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant