Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using custom param decorators #1728

Closed
1 task done
Toxicable opened this issue Dec 15, 2021 · 1 comment
Closed
1 task done

Support for using custom param decorators #1728

Toxicable opened this issue Dec 15, 2021 · 1 comment
Labels

Comments

@Toxicable
Copy link

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

While trying to integrate this package, we were unable to get @nestjs/swagger to pick up out custom route param decorators.

Describe the solution you'd like

Support for custom route param decorators could be added.
The problem is that this https://github.com/nestjs/swagger/blob/master/lib/services/parameter-metadata-accessor.ts#L69 parses custom decorators into NaN since keyPair[0] is a uuid from https://github.com/nestjs/nest/blob/master/packages/common/decorators/http/create-route-param-metadata.decorator.ts#L26 returns NaN , if we could detect this by possibly adding a new optional argument of type RouteParamtypes then the mapping would work.

Teachability, documentation, adoption, migration strategy

No response

What is the motivation / use case for changing the behavior?

Easier interoperability between features from the different nestjs packages

@kamilmysliwiec
Copy link
Member

#32

@nestjs nestjs locked and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants