-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog doesn't include breaking changes for v4 #142
Comments
Going through the same thing now, trying and failing to find a 4.0 changelog. |
Sorry I don't have time for it. Please submit a PR with changelog, you can use GitHub to compare changes. |
@mfazekas Apologies if you're busy, but can you speak to why this was a major version update? Are there any actual breaking changes? I've looked over the comparison between 3.0.0 and 4.0.0 and I don't believe I see any breaking changes (though I am unfamiliar with the implementation of the gem), but if that's the case then it has me question why it was a major version update in the first place. |
@ImOnMars we've upped net-ssh, and since net-ssh interface is leaking through to net-sftp interface, and net-ssh was a major version. We drop support for deprecated ruby versions at net-ssh and remove deprecated insecure cyphers. Also it's just safer for me to release a major new release, as there is no risk of breaking my consumers, in unexpected ways. |
@mfazekas Thanks! Appreciate the quick reply. |
Which ruby versions were dropped, and which ciphers? Thanks. |
Maybe I'm missing something, but this file was last updated 2 years ago. It would be great to have breaking changes listed in the changelog or readme for awareness during upgrades.
The text was updated successfully, but these errors were encountered: