Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog doesn't include breaking changes for v4 #142

Open
spaghetticode opened this issue Dec 21, 2022 · 6 comments
Open

Changelog doesn't include breaking changes for v4 #142

spaghetticode opened this issue Dec 21, 2022 · 6 comments

Comments

@spaghetticode
Copy link

Maybe I'm missing something, but this file was last updated 2 years ago. It would be great to have breaking changes listed in the changelog or readme for awareness during upgrades.

@spaghetticode spaghetticode changed the title Changelog doesn't include breaking changes for version 4 Changelog doesn't include breaking changes for v4 Dec 21, 2022
@uberllama
Copy link

Going through the same thing now, trying and failing to find a 4.0 changelog.

@mfazekas
Copy link
Collaborator

Sorry I don't have time for it. Please submit a PR with changelog, you can use GitHub to compare changes.

@ImOnMars
Copy link

ImOnMars commented Mar 9, 2023

@mfazekas Apologies if you're busy, but can you speak to why this was a major version update? Are there any actual breaking changes? I've looked over the comparison between 3.0.0 and 4.0.0 and I don't believe I see any breaking changes (though I am unfamiliar with the implementation of the gem), but if that's the case then it has me question why it was a major version update in the first place.

@mfazekas
Copy link
Collaborator

@ImOnMars we've upped net-ssh, and since net-ssh interface is leaking through to net-sftp interface, and net-ssh was a major version. We drop support for deprecated ruby versions at net-ssh and remove deprecated insecure cyphers. Also it's just safer for me to release a major new release, as there is no risk of breaking my consumers, in unexpected ways.

@ImOnMars
Copy link

@mfazekas Thanks! Appreciate the quick reply.

@jaredbeck
Copy link

jaredbeck commented May 31, 2023

We drop support for deprecated ruby versions at net-ssh and remove deprecated insecure cyphers.

Which ruby versions were dropped, and which ciphers? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants