Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd-forwarder-vpp should apply changes for the datapath in case of changing connection proto on refresh #441

Open
denis-tingaikin opened this issue Dec 12, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@denis-tingaikin
Copy link
Member

Description

Client or Endpoint could change connection proto-state on refresh requests. For example, change Mac addresses or IP addresses or change routes, and so on.

The question is: Should forwarder-vpp apply the change?

Use-case

  1. start basic NSM setup
  2. start endpoint for service 'ns-1'
  3. client requests service 'ns-1'
  4. NSM serves the request (nsmgr, forwarder-vpp, endpoiont does work)
  5. client gets connectivity
  6. client does refresh
  7. NSM serves the request
  8. endpoint changes Src/Dst addresses for the client's request

Actual: client still have old IPs

Expected: ?

@denis-tingaikin denis-tingaikin added the question Further information is requested label Dec 12, 2021
@denis-tingaikin
Copy link
Member Author

/cc @edwarnicke

@edwarnicke
Copy link
Member

@denis-tingaikin Do we know why the endpoint changed the Src/Dst IPs assigned?

@denis-tingaikin
Copy link
Member Author

denis-tingaikin commented Dec 12, 2021

@edwarnicke At this moment we did not face something similar in our examples. The question is about to do we allow endpoints to change datapath config in general on refresh.

@edwarnicke
Copy link
Member

@denis-tingaikin Ah... then yes, yes it should :)

@denis-tingaikin
Copy link
Member Author

OK, then we should fix it.

@denis-tingaikin denis-tingaikin added the bug Something isn't working label Dec 13, 2021
@denis-tingaikin
Copy link
Member Author

denis-tingaikin commented Dec 13, 2021

@edwarnicke Should this be considered before release v1.2.0?

@denis-tingaikin denis-tingaikin changed the title Question: Should cmd-forwarder-vpp apply changes for the datapath in case of changing connection proto on refresh? cmd-forwarder-vpp should apply changes for the datapath in case of changing connection proto on refresh Dec 14, 2021
@denis-tingaikin denis-tingaikin removed the question Further information is requested label Dec 14, 2021
@denis-tingaikin
Copy link
Member Author

denis-tingaikin commented Dec 14, 2021

@edwarnicke confirmed internally that the issue should be considered.

Denis Tingaikin 15 hours ago
@edwarnicke Should we consider this before v1.2.0?

Ed Warnicke 15 hours ago
if possible yes… I suspect that we will need something like it to resolve issues with vL3

@sol-0 sol-0 removed their assignment Dec 20, 2021
nsmbot pushed a commit that referenced this issue Jun 29, 2023
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#441

Commit: 83122c3
Author: Denis Tingaikin
Date: 2023-06-29 22:09:02 +0300
Message:
  - Merge pull request #441 from Nordix/go120
Signed-off-by: NSMBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants