make error！

[snakwu]

@denis-tingajkin

Cloning into 'coredns'...
remote: Enumerating objects: 21, done.
remote: Counting objects: 100% (21/21), done.
remote: Compressing objects: 100% (19/19), done.
remote: Total 57644 (delta 7), reused 5 (delta 2), pack-reused 57623
Receiving objects: 100% (57644/57644), 95.72 MiB | 2.62 MiB/s, done.
Resolving deltas: 100% (31201/31201), done.
go generate coredns.go
CGO_ENABLED=0 go build -v -ldflags="-s -w -X github.com/coredns/coredns/coremain.GitCommit=35b40a84-dirty" -o coredns
go: finding github.com/networkservicemesh/fanout latest
github.com/networkservicemesh/fanout

github.com/networkservicemesh/fanout

../../pkg/mod/github.com/networkservicemesh/[email protected]/setup.go:53:21: cannot use c (type *"github.com/caddyserver/caddy".Controller) as type *"github.com/coredns/caddy".Controller in argument to dnsserver.GetConfig
note: module requires Go 1.14
make: *** [Makefile:16: coredns] Error 2
snakwu@hassio-server:~/go-workspace/src/coredns$

[denis-tingaikin]

It looks like coredns have added changes that are incompatible with external plugins. So fanout plugin as other external plugins now can work only with latest fixed version v1.7.1

[snakwu]

@denis-tingajkin
External plug-in proxy, can also make normally
https://github.com/coredns/proxy.git

[denis-tingaikin]

@snakwu It is interesting. Will try to figure out why proxy still working :)

[snakwu]

@snakwu It is interesting. Will try to figure out why proxy still working :)

Thank you very much

[denis-tingaikin]

@snakwu I've found that coredns have updated logic in github.com/coredns/coredns/core/dnsserver (They created their caddy repo github.com/coredns/caddy). That's why fanout is not more compilable with the latest master.

Also, I've found that coredns project owner recently has updated proxy plugin manually coredns/proxy@076a800. That's why proxy is compilable

[snakwu]

@snakwu I've found that coredns have updated logic in github.com/coredns/coredns/core/dnsserver (They created their caddy repo github.com/coredns/caddy). That's why fanout is not more compilable with the latest master.

Also, I've found that coredns project owner recently has updated proxy plugin manually coredns/proxy@076a800. That's why proxy is compilable

在之前fanout不能编译时，我测试过proxy是可以正常编译的，然后coredns更新到了v1.7.1，proxy才更新的，然后一直没更新过了，fanout在v1.7.1刚出来时，你做了个修复，可以编译了，但不过两天又出错了，但proxy一直都能正常编译，所以说，能不能作为一个参考，来修复这个问题？

[denis-tingaikin]

@snakwu
The root cause is this line change coredns/proxy@076a800#diff-612ba582954ff6ec45c630abef6537e9L8

I do not think that we should update fanout plugin to latest coredns. Because in this case, we can face with bugs.

Could you investigate are other plugins combinable with latest coredns master? https://coredns.io/explugins/

[snakwu]

@snakwu
The root cause is this line change coredns/proxy@076a800#diff-612ba582954ff6ec45c630abef6537e9L8

I do not think that we should update fanout plugin to latest coredns. Because in this case, we can face with bugs.

Could you investigate are other plugins combinable with latest coredns master? https://coredns.io/explugins/

https://github.com/c-mueller/ads
这个插件也正常！

[denis-tingaikin]

@snakwu
This plugin https://github.com/c-mueller/ads is not compilable.

user@pc:~/go/src/github.com/coredns$ make
go generate coredns.go
CGO_ENABLED=0  go build -v -ldflags="-s -w -X github.com/coredns/coredns/coremain.GitCommit=0cb01365-dirty" -o coredns
go: finding module for package github.com/c-mueller/ads
go: downloading github.com/c-mueller/ads v0.2.4
go: found github.com/c-mueller/ads in github.com/c-mueller/ads v0.2.4
go: downloading golang.org/x/net v0.0.0-20200923182212-328152dc79b1
golang.org/x/net/internal/iana
golang.org/x/net/context
golang.org/x/net/internal/timeseries
golang.org/x/net/http2/hpack
golang.org/x/net/bpf
golang.org/x/net/idna
golang.org/x/net/internal/socket
golang.org/x/net/context/ctxhttp
golang.org/x/net/trace
golang.org/x/oauth2/internal
golang.org/x/net/ipv4
golang.org/x/net/ipv6
golang.org/x/oauth2
golang.org/x/net/http/httpguts
golang.org/x/net/http2
golang.org/x/oauth2/jwt
golang.org/x/oauth2/google
github.com/miekg/dns
k8s.io/apimachinery/pkg/util/net
google.golang.org/grpc/internal/transport
k8s.io/apimachinery/pkg/watch
k8s.io/client-go/transport
k8s.io/client-go/rest
google.golang.org/grpc
k8s.io/client-go/discovery
k8s.io/client-go/kubernetes/typed/authentication/v1beta1
k8s.io/client-go/kubernetes/typed/apps/v1beta1
k8s.io/client-go/kubernetes/typed/admissionregistration/v1
k8s.io/client-go/kubernetes/typed/authentication/v1
k8s.io/client-go/kubernetes/typed/authorization/v1
k8s.io/client-go/kubernetes/typed/autoscaling/v1
k8s.io/client-go/kubernetes/typed/authorization/v1beta1
k8s.io/client-go/kubernetes/typed/apps/v1
k8s.io/client-go/kubernetes/typed/admissionregistration/v1beta1
k8s.io/client-go/kubernetes/typed/apps/v1beta2
k8s.io/client-go/kubernetes/typed/autoscaling/v2beta1
k8s.io/client-go/kubernetes/typed/autoscaling/v2beta2
k8s.io/client-go/tools/cache
k8s.io/client-go/kubernetes/typed/batch/v1
k8s.io/client-go/kubernetes/typed/batch/v1beta1
github.com/coredns/coredns/plugin/pkg/response
github.com/coredns/coredns/plugin/pkg/parse
github.com/coredns/coredns/plugin/pkg/edns
github.com/coredns/coredns/plugin/pkg/doh
github.com/coredns/coredns/plugin/pkg/nonwriter
github.com/coredns/coredns/plugin/pkg/rcode
github.com/coredns/coredns/plugin/pkg/dnstest
github.com/coredns/coredns/plugin/file/rrutil
github.com/coredns/coredns/request
github.com/dnstap/golang-dnstap
github.com/coredns/coredns/plugin/test
k8s.io/client-go/kubernetes/typed/batch/v2alpha1
k8s.io/client-go/kubernetes/typed/certificates/v1
k8s.io/client-go/kubernetes/typed/certificates/v1beta1
github.com/coredns/coredns/plugin/pkg/dnsutil
k8s.io/client-go/kubernetes/typed/coordination/v1
github.com/coredns/coredns/plugin/file/tree
k8s.io/client-go/kubernetes/typed/coordination/v1beta1
k8s.io/client-go/kubernetes/typed/core/v1
k8s.io/client-go/kubernetes/typed/discovery/v1alpha1
k8s.io/client-go/kubernetes/typed/discovery/v1beta1
github.com/coredns/coredns/plugin/etcd/msg
k8s.io/client-go/kubernetes/typed/events/v1
github.com/coredns/coredns/plugin/dnstap/msg
k8s.io/client-go/kubernetes/typed/extensions/v1beta1
k8s.io/client-go/kubernetes/typed/events/v1beta1
k8s.io/client-go/kubernetes/typed/flowcontrol/v1alpha1
k8s.io/client-go/kubernetes/typed/networking/v1
github.com/coredns/coredns/plugin
k8s.io/client-go/kubernetes/typed/networking/v1beta1
k8s.io/client-go/kubernetes/typed/node/v1alpha1
github.com/coredns/coredns/plugin/dnstap/taprw
k8s.io/client-go/kubernetes/typed/node/v1beta1
k8s.io/client-go/kubernetes/typed/policy/v1beta1
k8s.io/client-go/kubernetes/typed/rbac/v1
k8s.io/client-go/kubernetes/typed/rbac/v1alpha1
k8s.io/client-go/kubernetes/typed/rbac/v1beta1
k8s.io/client-go/kubernetes/typed/scheduling/v1
k8s.io/client-go/kubernetes/typed/scheduling/v1alpha1
github.com/coredns/coredns/pb
github.com/grpc-ecosystem/grpc-opentracing/go/otgrpc
github.com/googleapis/gax-go/v2
google.golang.org/api/internal
go.etcd.io/etcd/etcdserver/etcdserverpb
k8s.io/client-go/kubernetes/typed/scheduling/v1beta1
k8s.io/client-go/kubernetes/typed/settings/v1alpha1
k8s.io/client-go/kubernetes/typed/storage/v1
k8s.io/client-go/kubernetes/typed/storage/v1alpha1
k8s.io/client-go/kubernetes/typed/storage/v1beta1
k8s.io/client-go/plugin/pkg/client/auth/gcp
github.com/coredns/coredns/plugin/metrics/vars
k8s.io/client-go/plugin/pkg/client/auth/oidc
k8s.io/client-go/plugin/pkg/client/auth/openstack
k8s.io/client-go/tools/auth
google.golang.org/api/option
github.com/coredns/coredns/core/dnsserver
google.golang.org/api/option/internaloption
google.golang.org/api/transport/http
k8s.io/client-go/tools/clientcmd
google.golang.org/api/dns/v1
github.com/coredns/coredns/coremain
github.com/coredns/coredns/plugin/any
github.com/coredns/coredns/plugin/bind
github.com/coredns/coredns/plugin/bufsize
github.com/coredns/coredns/plugin/transfer
github.com/coredns/coredns/plugin/cancel
github.com/coredns/coredns/plugin/pkg/upstream
github.com/coredns/coredns/plugin/chaos
github.com/coredns/coredns/plugin/dnstap
github.com/coredns/coredns/plugin/erratic
github.com/coredns/coredns/plugin/debug
github.com/coredns/coredns/plugin/errors
github.com/coredns/coredns/plugin/hosts
github.com/coredns/coredns/plugin/metadata
github.com/coredns/coredns/plugin/metrics
k8s.io/client-go/kubernetes
github.com/coredns/coredns/plugin/loadbalance
github.com/coredns/coredns/plugin/loop
github.com/coredns/coredns/plugin/nsid
github.com/coredns/coredns/plugin/ready
github.com/coredns/coredns/plugin/root
github.com/coredns/coredns/plugin/file
github.com/coredns/coredns/plugin/forward
github.com/coredns/coredns/plugin/grpc
github.com/coredns/coredns/plugin/k8s_external
github.com/coredns/coredns/plugin/tls
github.com/coredns/coredns/plugin/pkg/replacer
github.com/coredns/coredns/plugin/rewrite
github.com/coredns/coredns/plugin/whoami
github.com/c-mueller/ads
github.com/coredns/coredns/plugin/acl
github.com/coredns/coredns/plugin/autopath
github.com/coredns/coredns/plugin/cache
github.com/coredns/coredns/plugin/dns64
github.com/coredns/coredns/plugin/dnssec
github.com/coredns/coredns/plugin/template
github.com/coredns/coredns/plugin/trace
github.com/coredns/coredns/plugin/auto
github.com/coredns/coredns/plugin/azure
github.com/coredns/coredns/plugin/clouddns
github.com/coredns/coredns/plugin/log
# github.com/c-mueller/ads
../../../pkg/mod/github.com/c-mueller/[email protected]/setup.go:73:21: cannot use c (type *"github.com/caddyserver/caddy".Controller) as type *"github.com/coredns/caddy".Controller in argument to dnsserver.GetConfig
github.com/coredns/coredns/plugin/route53
github.com/coredns/coredns/plugin/secondary
github.com/coredns/coredns/plugin/sign
github.com/coredns/coredns/plugin/kubernetes
go.etcd.io/etcd/clientv3
github.com/coredns/coredns/plugin/etcd
Makefile:16: recipe for target 'cored

[snakwu]

@denis-tingajkin 哦，对不起，可能coerdns又更新了什么！
但是proxy是一直可正常的，不知道他怎么实现的，fanout如果可以解决这烦恼那实在是太好了，因为我一直很喜欢fanout，因为fanout在多个游来说，是要比其它的插件要快！

[denis-tingaikin]

@snakwu

Note: plugin proxy has been updated to latest coredns. Plugin fanout is working fine with the latest fixed coredns (v1.7.1).

Also, I've found that coredns project owner recently has updated proxy plugin manually coredns/proxy@076a800. That's why proxy is compilable

The root cause is this line change coredns/proxy@076a800#diff-612ba582954ff6ec45c630abef6537e9L8

[snakwu]

@denis-tingajkin
希望fanout能和最新代码很好的工作；）