Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update begin chain element #1649

Open
denis-tingaikin opened this issue Jul 25, 2024 · 1 comment
Open

Update begin chain element #1649

denis-tingaikin opened this issue Jul 25, 2024 · 1 comment
Assignees

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Jul 25, 2024

We've discovered that if we update begin close logic it fixes all iface leaks

@NikitaSkrynnik
Copy link
Contributor

@edwarnicke

We discussed the fix with timeout chain element and we think there is a problem with it.

If forwarder fails somewhere in the middle of its chain during request, there are two situations:

  1. Datapath is already configured
    In this case we must keep the connection alive as much as possible so timeout should be set to maximum value (lifetime of a token)

  2. Datapath is not configured yet
    In this case we should call Close as soon as possible to release the resources. timeout (or another chain element) should call Close immediately after receiving the error.

If timeout is always set to the maximum value and waits before closing then we don't release the resources in the second scenario.

The problem is that we can't check whether datapath is configured or not when we get the error on the forwarder

@NikitaSkrynnik NikitaSkrynnik moved this from In Progress to Blocked in Release v1.14.0 Aug 6, 2024
@NikitaSkrynnik NikitaSkrynnik moved this from Blocked to Under review in Release v1.14.0 Aug 7, 2024
@denis-tingaikin denis-tingaikin moved this from Under review to Moved to next release in Release v1.14.0 Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Moved to next release
Development

No branches or pull requests

2 participants