This repository has been archived by the owner on Sep 22, 2024. It is now read-only.
fix: more type checking errors #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great! Thank you! I'll merge this one for now, I opened https://github.com/netzo/netzo/issues/88 to track progress for the remaining errors |
miguelrk
referenced
this pull request
Feb 6, 2024
…c-analyzable dynamic import Chanes introduced in https://github.com/netzo/netzo/pull/87 are somehow leading to the following error in deployment "The deployment failed: UNCAUGHT_EXCEPTION TypeError: module not found: 'file:///src/fresh.gen.ts' at async Object.start (https://deno.land/x/[email protected]/core/mod.ts:113:23) ". This is an attempt to fix it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/netzo/netzo/issues/85
@miguelrk, as detailed in the comment in the issue, the approach here runs and makes the type checker happy.
There were a few miscellaneous fixes as well, in order to get the
check:typestask to even run... It now finally tells me:I guess there's some more work to do 😅