Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform data with any valid projection matrix #418

Open
eigenvivek opened this issue Jan 21, 2021 · 1 comment
Open

Transform data with any valid projection matrix #418

eigenvivek opened this issue Jan 21, 2021 · 1 comment
Assignees

Comments

@eigenvivek
Copy link
Member

eigenvivek commented Jan 21, 2021

Is your feature request related to a problem? Please describe.
Supersedes #417

Describe the solution you'd like
We're planning a bunch of new MORF experiments with different types of patches (convolutional filters, gabor filters, etc.)

Allowing the user to define and pass their own projection matrix sampling functions would make these experiments a lot easier, rather than having a new splitter class for every patch sampling method we want to try

I'm proposing modifying ObliqueSplitter's sample_proj_matrix to allow for user-defined matrix sampling methods.

Alternatively, i could make a new splitter class with this functionality

@levinwil @jdey4 @PSSF23 what do y'all think?

@PSSF23
Copy link
Member

PSSF23 commented Jan 21, 2021

I personally think that modifying the existing function makes more sense, so it could save us an additional splitter class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants