Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify compute_bounds function #325

Open
tathey1 opened this issue Nov 3, 2021 · 5 comments
Open

Simplify compute_bounds function #325

tathey1 opened this issue Nov 3, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tathey1
Copy link
Member

tathey1 commented Nov 3, 2021

There is a function that, given a component in a segmentation, computes the bounding box with a certain padding (here). However this can be simplified by utilizing the regionprops method in skimage.

I could see the mpnp constructor computing regionprops on the labels then saving this as a state variable. Then, compute_bounds could use the 'bbox' field in the region props to compute the padded bounds.

@tathey1 tathey1 added enhancement New feature or request good first issue Good for newcomers labels Nov 3, 2021
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Stale issue message

@github-actions
Copy link

Stale issue message

Swarnlataaa added a commit to Swarnlataaa/brainlit that referenced this issue May 29, 2023
Swarnlataaa added a commit to Swarnlataaa/brainlit that referenced this issue May 29, 2023
@Swarnlataaa
Copy link

please assign the issue to me.

@anviimishra
Copy link

I'm interested in helping with this!

@tathey1
Copy link
Member Author

tathey1 commented Sep 7, 2023

Things have updated since I posted this so the function in question is here now. It would be good to sketch out (like on paper) what the change would involve. i.e. is there going to be a new class attribute/variable? If so when will it be initialized? Maybe we should set up a timing benchmark experiment to make sure that any changes would actually be faster because that's the number one priority at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants