-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify compute_bounds function #325
Comments
Stale issue message |
Stale issue message |
please assign the issue to me. |
I'm interested in helping with this! |
Things have updated since I posted this so the function in question is here now. It would be good to sketch out (like on paper) what the change would involve. i.e. is there going to be a new class attribute/variable? If so when will it be initialized? Maybe we should set up a timing benchmark experiment to make sure that any changes would actually be faster because that's the number one priority at this point. |
There is a function that, given a component in a segmentation, computes the bounding box with a certain padding (here). However this can be simplified by utilizing the regionprops method in skimage.
I could see the mpnp constructor computing regionprops on the labels then saving this as a state variable. Then, compute_bounds could use the 'bbox' field in the region props to compute the padded bounds.
The text was updated successfully, but these errors were encountered: