Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication Tests #430

Open
Aeusman opened this issue Mar 6, 2017 · 3 comments
Open

Authentication Tests #430

Aeusman opened this issue Mar 6, 2017 · 3 comments
Assignees

Comments

@Aeusman
Copy link
Contributor

Aeusman commented Mar 6, 2017

[On Hold] - Pending a decision about how we want to deal with the new setup script in 16.

@Aeusman Aeusman self-assigned this Mar 6, 2017
@kunallillaney
Copy link
Collaborator

@Aeusman Here is what I recommend:
We should create multiple modes of the same test. One mode runs all these tests as they are on public projects(which is the case now) and have a second mode which runs against all private projects with a pre-created token(as you had earlier). Let's create a token on install (only when installing on travis) and go thorough mode1 and mode2. We can set this mode via providing a conditional command-line argument to py.test which defaults always to mode1.
Does this sound reasonable?

@Aeusman
Copy link
Contributor Author

Aeusman commented Mar 10, 2017

Sounds reasonable to me. I'll implement this probably inside test_settings, and do something inside the trais model to test in this way. It might be challenging to do this in a purely py.test environment.

@kunallillaney
Copy link
Collaborator

I don't think test_settings will work since we want to run both tests. Let's discuss this offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants