Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate relationships when adding multiple entries in the Dashboard #25

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

JBBianchi
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
Ensure that RelationshipEditorModal resets its state with a new instance of ProjectionRelationshipDefinition after a relationship is created. This prevents previously entered relationships from being overwritten and ensures each added relationship is stored correctly.

Closes #24

Special notes for reviewers:

Additional information (if needed):

…entries

Ensure that RelationshipEditorModal resets its state with a new instance of ProjectionRelationshipDefinition after a relationship is created. This prevents previously entered relationships from being overwritten and ensures each added relationship is stored correctly.

Closes #24

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
@JBBianchi JBBianchi requested a review from cdavernas February 12, 2025 11:52
@JBBianchi JBBianchi self-assigned this Feb 12, 2025
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks ❤️

@JBBianchi JBBianchi merged commit 3b703cc into main Feb 12, 2025
6 checks passed
@JBBianchi JBBianchi deleted the fix-24-dashboard-relationships-duplication branch February 12, 2025 12:10
@JBBianchi JBBianchi added this to the v1.0.0 milestone Feb 12, 2025
@cdavernas cdavernas removed this from the v1.0.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding multiple relationships in "Projection Type" duplicates the last entry
2 participants