Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when writing/reading empty NIRNodes #120

Open
Jegp opened this issue Dec 9, 2024 · 0 comments
Open

Throw an error when writing/reading empty NIRNodes #120

Jegp opened this issue Dec 9, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Jegp
Copy link
Collaborator

Jegp commented Dec 9, 2024

NIRNodes are supposed to be abstract and not appear in graphs. When they are instantiated and written/read to/from graphs, we should raise an error.
Currently, we get an empty assertion error if we try to read a serialized graph with NIRNodes.
@Jegp Jegp added bug Something isn't working good first issue Good for newcomers labels Dec 9, 2024
hanleyc01 added a commit to hanleyc01/NIR that referenced this issue Jan 20, 2025
@hanleyc01
Throw attribute error NIRNode constructor
6774e19 
Fix for neuromorphs#120

Throws `AttributeError` on call `NIRNode.__init__`.
@hanleyc01 hanleyc01 mentioned this issue Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jegp