Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: sometime onOpen method is invoked before onICEServers: method in APPRTCAppDelegate #2

Open
YK-Unit opened this issue Mar 6, 2014 · 0 comments
Open

BUG: sometime onOpen method is invoked before onICEServers: method in APPRTCAppDelegate #2

YK-Unit opened this issue Mar 6, 2014 · 0 comments

Comments

@YK-Unit
Copy link

YK-Unit commented Mar 6, 2014

because of multithreaded's uncertainty, sometimes the onOpen method is invoked before onICEServers: method in APPRTCAppDelegate, then the peerConnection won't crate offer sdp successfully, beacuse the peerConnection is NULL at that time.

How to slove it?
In APPRTCAppClient, initialize GAEChannelClient in updateICEServers:withTurnServer: method rather in connectionDidFinishLoading: method
YK-Unit added a commit to YK-Unit/webrtc-ios that referenced this issue Mar 6, 2014
@YK-Unit
fix bug:issue_2
4e517c9 
fix bug:issue_2(newOcean#2) to make sure onICEServers: method will be incoked before onOpen method in APPRTCAppDelegate.
@YK-Unit YK-Unit mentioned this issue Mar 6, 2014
Merged
YK-Unit added a commit to YK-Unit/webrtc-ios that referenced this issue Mar 6, 2014
@YK-Unit
fix bug:issue_2
037d186 
fix bug:issue_2(newOcean#2) to make sure onICEServers: method incoked before onOpen method in APPRTCAppDelegate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YK-Unit