Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question or feature request: Why we can't use service name instead of GUID? #58

Open
vitalykarasik opened this issue Feb 15, 2024 · 4 comments

Comments

@vitalykarasik
Copy link

The action requests "The entity GUID to apply the deployment marker" for each deploy event. It means I have to collect a list of GUIDs for all services across all environments and use them in my workflow.

But we already have a 'service name' in both NewRelic and GH workflow. So why don't use it instead of GUID for calling this action?

@oleksandr-kinship
Copy link

oleksandr-kinship commented Jul 5, 2024

@vitalykarasik have you got any answer?
have the same question, +1

@vitalykarasik
Copy link
Author

@vitalykarasik have you got any answer? have the same question, +1

@oleksandr-kinship unfortunately, no.
I'm just adding GUID for each service into its CI/CD workflow - hardcoded :-(

@oleksandr-kinship
Copy link

@vitalykarasik have you got any answer? have the same question, +1

@oleksandr-kinship unfortunately, no. I'm just adding GUID for each service into its CI/CD workflow - hardcoded :-(

That upset to have to use antipatterns.
Thanks. for quick answer!

@oleksandr-kinship
Copy link

Hello @vitalykarasik,
bit think about how it could be integrated without minimal hardcode for big amount of applications, so I think I have found the most straightforward solution - write reusable action that will call NR api to get guid first, then use this output in deployment marker arguments.
As base for get_uid can be used this action, just use another cli call

newrelic apm application search \
            --name ${NEW_RELIC_APM_NAME}

then this possible to grep/jq guid from response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants