AWS SDK v3 DynamoDB - [email protected] (v7.0.0 of this lib) no longer record DynamoDB on Databases APM tab

[huntharo]

Description

• See detailed notes and reproducible example here: Newrelic demo pwrdrvr/dynamodb-session-store#19
• DynamoDB access using [email protected] logs DB access on the Database tab of APM, logging the specific operations, rates, and times
• DynamoDB access using [email protected] logs DB access only as External Services of APM
• This PR appears to be a candidate of why this changed (but does not note this as intentional) as it removed the lib-dynamodb and client-dynamodb instrumentation and shifted the responsibility entirely to smithy-client: feat: updated aws sdk v3 instrumentation to function with require-in-… #205

Expected Behavior

• DynamoDB access should be logged in detail on the Database tab of APM

Troubleshooting or NR Diag results

• See full details and logs: Newrelic demo pwrdrvr/dynamodb-session-store#19

Steps to Reproduce

• See full reproduction steps and code on an open source project that demos this: Newrelic demo pwrdrvr/dynamodb-session-store#19

Your Environment

• Node version: 16.17.1
• Operating System and version: Mac OS X and node:18.17-alpine3.18 Docker image

Additional context

[workato-integration]

https://issues.newrelic.com/browse/NR-161353

[bizob2828]

Hi @huntharo a support rep here brought this to our attention. Thanks for the repro case, it will make it easier to triage this issue. Sorry for the troubles

[bizob2828]

Ok, I see the issue. When we moved our instrumentation from instrumenting @aws-sdk/lib-dynamodb and @aws-sdk/client-dynamodb, we neglected to include checking for a class that gets exported in @aws-sdk/lib-dynamodb DynamoDBDocument. Your wrapper code creates a client from that here.

[bizob2828]

@huntharo the fix for this has been released in 7.0.1

[huntharo]

@huntharo the fix for this has been released in 7.0.1

Thank you! Yup, I have confirmed in my test case app that the issue was resolved and just deployed this to Prod in our app that was using this and confirmed it was resolved there as well with 7.0.1. Thanks!