From 0ac771008a0c49bf57dbea47c5a7b0ec318e13f1 Mon Sep 17 00:00:00 2001 From: Corbin Phelps Date: Wed, 22 Aug 2018 11:21:08 -0400 Subject: [PATCH 1/3] Added some missing metrics --- src/metrics/broker_definitions.go | 4 ++-- src/metrics/producer_definitions.go | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/metrics/broker_definitions.go b/src/metrics/broker_definitions.go index b4d4cc1a..da5ee358 100644 --- a/src/metrics/broker_definitions.go +++ b/src/metrics/broker_definitions.go @@ -48,12 +48,12 @@ var brokerMetricDefs = []*JMXMetricSet{ MetricPrefix: "kafka.network:type=RequestMetrics,name=TotalTimeMs,request=Offsets,", MetricDefs: []*MetricDefinition{ { - Name: "request.avgTimeUpdateMetadata", + Name: "request.avgTimeOffset", SourceType: metric.GAUGE, JMXAttr: "attr=Mean", }, { - Name: "request.avgTimeUpdateMetadata99Percentile", + Name: "request.avgTimeOffset99Percentile", SourceType: metric.GAUGE, JMXAttr: "attr=99thPercentile", }, diff --git a/src/metrics/producer_definitions.go b/src/metrics/producer_definitions.go index df77ab2f..0fe1a0a3 100644 --- a/src/metrics/producer_definitions.go +++ b/src/metrics/producer_definitions.go @@ -147,6 +147,11 @@ var ProducerTopicMetricDefs = []*JMXMetricSet{ SourceType: metric.GAUGE, JMXAttr: "attr=record-send-rate", }, + { + Name: "producer.avgCompressionRateRecordBatches", + SourceType: metric.GAUGE, + JMXAttr: "attr=compression-rate", + }, }, }, } From 280e7606e5348c25a0303c2aa8c2e360da3346f5 Mon Sep 17 00:00:00 2001 From: Corbin Phelps Date: Wed, 22 Aug 2018 12:26:14 -0400 Subject: [PATCH 2/3] Found missing record accumulator metric --- src/metrics/producer_definitions.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/metrics/producer_definitions.go b/src/metrics/producer_definitions.go index 0fe1a0a3..061ce9ea 100644 --- a/src/metrics/producer_definitions.go +++ b/src/metrics/producer_definitions.go @@ -114,6 +114,11 @@ var producerMetricDefs = []*JMXMetricSet{ SourceType: metric.GAUGE, JMXAttr: "client-id=" + producerHolder + ",attr=request-size-max", }, + { + Name: "producer.avgRecordAccumulatorsInMiliseconds", + SourceType: metric.GAUGE, + JMXAttr: "client-id=" + producerHolder + ",attr=record-queue-time-avg", + }, }, }, { From d6f6cdb856fba86e7ed2c74be79e819bf74388e5 Mon Sep 17 00:00:00 2001 From: Corbin Phelps Date: Wed, 22 Aug 2018 12:32:01 -0400 Subject: [PATCH 3/3] Fixed mispelling for metric --- src/metrics/producer_definitions.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/metrics/producer_definitions.go b/src/metrics/producer_definitions.go index 061ce9ea..f2e36b6b 100644 --- a/src/metrics/producer_definitions.go +++ b/src/metrics/producer_definitions.go @@ -115,7 +115,7 @@ var producerMetricDefs = []*JMXMetricSet{ JMXAttr: "client-id=" + producerHolder + ",attr=request-size-max", }, { - Name: "producer.avgRecordAccumulatorsInMiliseconds", + Name: "producer.avgRecordAccumulatorsInMilliseconds", SourceType: metric.GAUGE, JMXAttr: "client-id=" + producerHolder + ",attr=record-queue-time-avg", },