Fix Various Android Studio Findings

[alexknop]

When running Analyze Code in Android Studio, there are some interesting suggestions that come up.

Before I attempt to fix things and submit PRs I just wanted to see if I had the green light to fix things such as
-Use of deprecated Owncloud (and other libraries) functions when alternatives are available
-Not using Java best practices in the code.

If I submitted smaller and compartmentalized PRs for these various issues, would this be encouraged and have a good chance of being merged?

I would like to tidy up the code and see if more efficient ways of doing things could help this project, but don't want to overrun app architecture and project goals.

If you have any pointers on where I could begin or focus on for now, I'm up for the task. Personally, deprecated functions interests me the most at this time.

[AndyScherzinger]

Hi @alexknop and welcome!

I short, yes, that would be very much appreciated and has a high chance of getting merged especially like you mentioned when sticking to small, easy to review PRs.

We do run the linter, spotbugs as part of the Github actions and always aim to not raise the number of issues, best case lower them 👍

Looking forward to the contributions 🤩

[AndyScherzinger]

I also sent you an invitation to the Github org of Nextcloud. This way you don't have to work via a fork for contributions any longer. Might make life a bit easier when it comes to rebasing things to latest master and also ensures all Github actions are executed, since some actions in some repos will on get executed on the org, not on forks.