Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal links don't work anymore in existing collective #1490

Open
thopanX opened this issue Sep 18, 2024 · 1 comment
Open

Internal links don't work anymore in existing collective #1490

thopanX opened this issue Sep 18, 2024 · 1 comment
Labels
bug Something isn't working needs info

Comments

@thopanX
Copy link

thopanX commented Sep 18, 2024

Describe the bug
I created a collective about 2 years ago with working links to other (sub-)pages. I came back to the collective to look through it in view mode and noticed that internal links didn't work anymore. On click I got a small pop-over in which I can copy the page adress and/or click on it which opens a new browser tab. (Is that the new default for clicking a link in view mode?) The structure of links is https://[domain]/apps/collectives/Organisationen/Readme.md?fileId=21324 – the collective name, DreiDinge, is omitted in internal links after /collectives/, /Organisationen/ is a parent page with subpages.

Links in the left sidebar of the collective are structured like https://[domain]/apps/collectives/DreiDinge/Orte/Borne?fileId=22585 and work fine. If I add internal links via the link button today, the structure of links is https://[domain]/f/21393. If I use the Smart Picker links are correct. I'm pretty confused. How do I get the collective working again?

To Reproduce
Steps to reproduce the behavior:
I don't know how to reproduce this. My Nextcloud instance got updated during the past two years including the Collectives app.

Expected behavior
I'd expect internal links in view mode to function properly and take me to the linked collective page.

Server details:

  • Collectives app version: 2.14.3
  • Nextcloud version: 30.0.0
  • PHP Version: 8.1
  • Database: ?

Client details:

  • OS: Fedora Linux and macOS 14.7
  • Browser: Firefox
  • Browser version: 130.0.0
  • Device: desktop
@thopanX thopanX added the bug Something isn't working label Sep 18, 2024
@mejo-
Copy link
Member

mejo- commented Oct 22, 2024

Dear @thopanX, thanks for your report. We indeed refactored the link handling quite a bit in recent releases of Text and Collectives, as there were many issues with the old way it worked.

The biggest change you already discovered: clicking on a link will open a popover now, where you can either edit, copy or open the link. This is the new behaviour and it was added for accessibility reasons.

Regarding adding a link, there's several ways to insert a link to a collective page:

  1. Drag & drop from the page sidebar inserts the link to the page in the format /apps/collectives/<collective>/<page>?fileId=<id>, which means the page will will open inside Collectives
  2. Adding a collectives page with the Smartpicker will result in the same.
  3. Adding a link via the "Insert link -> Link to file or folder" menu action will link to the file (in Files app), not to the Collective page. This means, the file will be opened in the Viewer (in an overlay modal). We're aware that this is confusing. See the first item of Linking pages improvements (meta issue) #1026 where it is tracked.

The remaining question would be why your old links broke. Could you please paste the markdown content of the page with broken links, so I can have a closer look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs info
Projects
Status: 📄 To do (~10 entries)
Development

No branches or pull requests

2 participants