-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contacts corrupts contact between import and export of same contact #1850
Comments
Same applies to RELATED, parameters are soaked up into TYPE. Possibly a generic problem with TYPE interpretation? from
to
|
I cannot reproduce it exactly like that. When I import your vCard I am "only" losing some It might be related to an issue I fixed on server lately and that will come with the next update: nextcloud/server#20544 Here is how it looks for me: generated contact for import
exported from Nextcloud
EDIT: I found out the order is important. See below, after moving generated contact for import
exported from Nextcloud
|
Interesting that PREF causes loss of TYPE but TYPE soaks up everything behind it into a useless value that is lost/discarded down the track, by clients that sync and discard the TYPE value, then sync back the contact minus the TYPE. Or something like that. :) Is it possible to stop syncing of contacts with external clients, such as Thunderbird+CardBook and iPhones, so tests can be done in isolation? CardBook add-on for Thunderbird isn't exactly perfect either and iPhones are notorious for using ITEM entries. I am happy to participate in testing and validation against the RFC, if there is a framework that tests contacts in isolation. Unfortunately all I have is Win10 at the moment, my linux machine wont be available to me till November (Stuck in Sydney, live in Adelaide). My NextCloud instance is hosted on a shared linux server and I actively use it, so am somewhat hesitant to 'break' it. ...Lyall |
In your linked RFC the Considering debug: can't you just deactivate the account on your phone and quit Thunderbird? Otherwise I can only help with linux. |
Good call!
when I expected to see (having lost the preferred order, as dictated by the
So, exporting from Contacts seems good, CardBook not. I will trawl through my entire contacts vCard entries and fix the |
I think both variants ( |
PREF defaults to value 1, if no value supplied. The use of Regarding testing, come November 2020, feel free to contact me regarding testing, as I will have access to my linux by then 👍 |
Yes, something weird is going on.
There is an opened issue about the quotes around @lyallp your vcards are have the 4.0 VERSION field, right? |
All references in my post are for vCard 3.0 as per RFC 6350 |
Rfc rfc6350 is vcard 4 :) |
Whoops, you are entirely correct, so..., Contacts exports contact vcf files with vCard 4 entries yet labels the file with a |
Well, my phone lets me chose exactly one PREF per field, which will then be pre-selected when I want to contact that person. So it does make sense to keep the PREF without numbers, but only for one of them. |
So, Nextcloud contacts doesn't support pref yet (#202) Our lib knows the diff between vcard3 and vcard4. |
I exported a contact from NextCloud Contacts and tweaked entries manually. |
I found that if I import a v4 vCard into NextCloud contacts, refresh and immediately download the contact, the download is converted to v3 vCard including removal of PREF fields and altering the PHOTO to version 3.0 format. Additionally, when synced to Thunderbird Cardbook, the vCard is 3.0, thus losing PREF entries, even though CardBook supposedly accepts v4.0 vCards. Thus, whilst Contacts accepts v4.0, it seems to convert to v3.0 in most fields. |
|
|
My apologies if I have been stating the obvious. |
Well, not really "obvious", you have to find those issues ^^ So the issue here is only about the downloaded vcard? |
The last issue seems to be the conversion to v3.0 on download. |
This is all very complicated. I am unsure where problems exists, Contacts, CardBook or even iPhone Contacts. My CardBook Address book is vCard 3.0. I have re-created my CardBook AddressBook as v4.0 Sync from NextCloud seems mostly ok, except all PREF fields are set to 1. Once iPhone gets hold of the contact, via NextCloud sync, all things go to hell in a hand basket with emails and addresses converted to ITEM# entries, which royally screws the display of the contact in NextCloud Contacts. I recreated the CardBook AddressBook as v3.0, iPhone still screws the vCard, but still, CardBook deals with the altered vCard better than NextCloud Contacts, which does not display the ITEM# fields 🙁 I am starting to regret diving down this rabbit hole! I will continue to fiddle, and report back. |
I checked the NextCloud database, oc_cards and oc_cards_properties seem to be exactly as you and I suspected, blob is v4.0 and properties correspond to the vCard. |
I use NextCloud, Contacts App, synced to both iPhone and email client Thunderbird CardBook addon. They all fight each other during sync. Ok, NextCloud Contacts will load and store vCard 4.0. CardBook add-on syncs, throws away stuff like PREF=<anything other than 1> iPhone converts many fields to ITEM# CardBook does a reasoable job of displaying all the fields resulting from the iPhone mash up, except RELATED NextCloud Contacts, whilst having all the info in the knackered vCard from the iPhone, The iPhone seems to do a good job after it has knackered the vCard. It appears I must choose a platform as my 'reference' and ignore the other two. I dont use any web based services because I cannot guarantee they will be there sigh... this issue is a combination of 3. |
Steps to reproduce
vcard file corrupted
Expected behaviour
vcard format according to RFC - PREF=1..100, not text. Whole meaning of PREF is lost as it is soaked up by text string.
Additionally, expect TYPE=Bogus to show in web UI as Bogus, but Bogus is lost somewhere, leaving the web UI with defaults.
Actual behaviour
converts to
Server configuration detail
Operating system: Linux 2.6.32-954.3.5.lve1.4.78.el6.x86_64 nextcloud/server#1 SMP Thu Mar 26 08:20:27 EDT 2020 x86_64
Webserver: LiteSpeed (litespeed)
Database: mysql 5.6.49
PHP version:
7.4.11
Modules loaded: Core, date, libxml, openssl, pcre, sqlite3, zlib, bz2, calendar, ctype, curl, hash, filter, ftp, gettext, gmp, SPL, iconv, pcntl, readline, Reflection, session, standard, shmop, SimpleXML, mbstring, tokenizer, xml, litespeed, bcmath, dom, fileinfo, gd, imagick, imap, intl, json, exif, mysqli, mysqlnd, PDO, pdo_mysql, pdo_sqlite, Phar, posix, soap, sockets, timezonedb, xmlreader, xmlrpc, xmlwriter, xsl, zip, Zend OPcache
Nextcloud version: 20.0.0 - 20.0.0.9
Updated from an older Nextcloud/ownCloud or fresh install: updated
Where did you install Nextcloud from: unknown
Signing status
Array
(
)
List of activated apps
Configuration (config/config.php)
Are you using external storage, if yes which one: local/smb/sftp/...
Are you using encryption:
Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
Client configuration
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36
Operating system:
Logs
Web server error log
Nextcloud log
Browser log
Insert your browser log here, this could for example include:
The text was updated successfully, but these errors were encountered: