Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker compose examples to move way from deprecated --link #2087

Closed
tippexs opened this issue Oct 19, 2023 · 2 comments
Closed

Update docker compose examples to move way from deprecated --link #2087

tippexs opened this issue Oct 19, 2023 · 2 comments

Comments

@tippexs
Copy link

tippexs commented Oct 19, 2023

First of all this repository contains awesome examples and getting started configuration! Well done!

I was just working on a issue #1063 and updated my docker compose files to the latest API Version 3 and removed the deprecated --link option. As it is still supported in Version 2, Docker recommends the ussage of networks. See: https://docs.docker.com/compose/compose-file/compose-file-v2/#links

Before creating a PR I just want to be sure they are welcome and an update to compose V3 is appropriate! Happy to drop a PR to update the README.md docker compose exmaples.

https://github.com/nextcloud/docker/blob/master/README.md#base-version---apache

Keep up the great work!
Cheers Timo

@joshtrichards joshtrichards added examples Compose/Dockerfile/etc enhancement docs and removed examples Compose/Dockerfile/etc labels Oct 22, 2023
@tippexs
Copy link
Author

tippexs commented Oct 27, 2023

@joshtrichards thanks for adding the labels and sorry for my late response! I will work on the PR and submit it once I am back in my office. Currently in transit over the atlantic ocean. ✈️

@joshtrichards joshtrichards changed the title Documentation: Update docker compose examples Update docker compose examples to move way from deprecated --link Nov 5, 2023
@joshtrichards
Copy link
Member

Closing since other PRs have now eliminated the --link usage. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants