Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential Logic Issue in GetLocksOlderThan Methods Data Retrieval. #264

Open
zhiqi-23 opened this issue Mar 20, 2024 · 1 comment · May be fixed by #497
Open

Potential Logic Issue in GetLocksOlderThan Methods Data Retrieval. #264

zhiqi-23 opened this issue Mar 20, 2024 · 1 comment · May be fixed by #497
Labels
1. to develop bug Something isn't working

Comments

@zhiqi-23
Copy link

The GetLocksOlderThan (int $timeout) method cannot retrieve data. The 149 lines of this method are the conditions for data query, which cannot retrieve data. Because "$timeout" is the set time (in minutes), and the creation field in the files_lock data table is a unix timestamp, a 10 digit integer number$ Timeout * 60 is impossible to exceed the value of the creation field, which means that data cannot be retrieved. Is there a problem with this logic.
@susnux susnux added bug Something isn't working 1. to develop labels Aug 13, 2024
@AT-StephenDetomasi
Copy link

AT-StephenDetomasi commented Aug 24, 2024 •
edited
Loading

That looks like 27.0.x code but I am seeing this issue on 29.0.x as well.

max-nextcloud added a commit that referenced this issue Jan 20, 2025
@max-nextcloud
fix(timeout): compare creation time to now - timeout
43b7e2f 
Fixes #264.

Signed-off-by: Max <[email protected]>
@max-nextcloud max-nextcloud linked a pull request Jan 20, 2025 that will close this issue
Open
max-nextcloud added a commit that referenced this issue Feb 5, 2025
@max-nextcloud
fix(timeout): compare creation time to now - timeout
142e390 
Fixes #264.

Signed-off-by: Max <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(timeout): compare creation time to now - timeout nextcloud/files_lock
3 participants
@susnux @zhiqi-23 @AT-StephenDetomasi